[Mesa-dev] [PATCH v2] configure.ac: ensure RM is set

2015-10-09 Thread Jonathan Gray
GNU make predefines RM to rm -f but this is not required by POSIX so ensure that RM is set. This fixes "make clean" on OpenBSD. v2: use AC_CHECK_PROG Signed-off-by: Jonathan Gray CC: "10.6 11.0" --- configure.ac | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.ac b/configure.ac

[Mesa-dev] [PATCH] nouveau: avoid emitting new fences unnecessarily

2015-10-09 Thread Ilia Mirkin
Right now we emit on every kick, but this is only necessary if something will ever be able to observe that the fence completed. If there are no refs, leave the fence alone and emit it another day. This also happens to work around an issue for the kick handler -- a kick can be a result of e.g. nouv

Re: [Mesa-dev] [PATCH 0/9 v3] Apply GLSL ES initializer restrictions

2015-10-09 Thread Matt Turner
I sent a couple of small comments. The series is Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/4] program: remove unused function _mesa_find_line_column

2015-10-09 Thread Ian Romanick
It looks like the last user of this function was removed by Ken in 2012 (2f350f3). Kill it with fire. This patch is Reviewed-by: Ian Romanick On 10/07/2015 05:11 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/program/program.c | 43 ---

Re: [Mesa-dev] [PATCH 8/9] glsl: In later GLSL versions, sequence operator is cannot be a constant expression

2015-10-09 Thread Matt Turner
On Fri, Oct 9, 2015 at 6:53 PM, Ian Romanick wrote: > From: Ian Romanick > > Fixes: > ES3-CTS.shaders.negative.constant_sequence > > spec/glsl-es-3.00/compiler/global-initializer/from-sequence.vert > spec/glsl-es-3.00/compiler/global-initializer/from-sequence.frag > > Signed-off-by: I

Re: [Mesa-dev] [PATCH 2/9] ff_fragment_shader: Use binding to set the sampler unit

2015-10-09 Thread Matt Turner
On Fri, Oct 9, 2015 at 6:52 PM, Ian Romanick wrote: > From: Ian Romanick > > This is the way layout(binding=xxx) works from GLSL. The old method > just happened to work (and significantly predated support for > layout(binding=xxx)), but future changes will break this. > > Signed-off-by: Ian Roma

Re: [Mesa-dev] [PATCH 1/9] glsl: Allow built-in functions as constant expressions in OpenGL ES 1.00

2015-10-09 Thread Matt Turner
On Fri, Oct 9, 2015 at 6:52 PM, Ian Romanick wrote: > From: Ian Romanick > > In d4a24745 (August 2012), Paul made functions calls not be constant > expressions in GLSL ES 1.00. Since this feature was added in desktop > GLSL 1.20, we believed that it was added in GLSL ES 3.00. That turns > out t

Re: [Mesa-dev] [PATCH 9/9] glsl: Never allow the sequence operator anywhere in an array size

2015-10-09 Thread Ian Romanick
On 10/09/2015 06:53 PM, Ian Romanick wrote: > From: Ian Romanick > Forgot to add: Fixes: spec/glsl-1.20/compiler/structure-and-array-operations/array-size-sequence-in-parenthesis.vert spec/glsl-es-1.00/compiler/array-sized-by-sequence-in-parenthesis.vert spec/g

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/9] ff_fragment_shader: Use binding to set the sampler unit

2015-10-09 Thread Chris Forbes
The comment above this about the cast to int can probably go away? - Chris On Sat, Oct 10, 2015 at 2:52 PM, Ian Romanick wrote: > From: Ian Romanick > > This is the way layout(binding=xxx) works from GLSL. The old method > just happened to work (and significantly predated support for > layout

[Mesa-dev] [PATCH 0/9 v3] Apply GLSL ES initializer restrictions

2015-10-09 Thread Ian Romanick
So, this should have been a quick, easy fix. One thing led to another, and here we are at v3 of a 9 patch series. There were some old bugs hanging around the code that we either never noticed or just happend to work out okay. The first 4 patches in the series resolve those issues. Patch 1 fixes

[Mesa-dev] [PATCH 6/9] glsl: Restrict initializers for global variables to constant expression in ES

2015-10-09 Thread Ian Romanick
From: Ian Romanick v2: Combine this check with the existing const and uniform checks. This change depends on the previous patch (glsl: Only set ir_variable::constant_value for const-decorated variables). Fixes: ES2-CTS.shaders.negative.initialize ES3-CTS.shaders.negative.initialize

[Mesa-dev] [PATCH 3/9] glsl/linker: Use constant_initializer instead of constant_value to initialize uniforms

2015-10-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: "10.6 11.0" --- src/glsl/link_uniform_initializers.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/link_uniform_initializers.cpp b/src/glsl/link_uniform_initializers.cpp index 0918d2a..065257b 100644 --- a

[Mesa-dev] [PATCH 1/9] glsl: Allow built-in functions as constant expressions in OpenGL ES 1.00

2015-10-09 Thread Ian Romanick
From: Ian Romanick In d4a24745 (August 2012), Paul made functions calls not be constant expressions in GLSL ES 1.00. Since this feature was added in desktop GLSL 1.20, we believed that it was added in GLSL ES 3.00. That turns out to be completely wrong. Built-in functions have always been allo

[Mesa-dev] [PATCH 2/9] ff_fragment_shader: Use binding to set the sampler unit

2015-10-09 Thread Ian Romanick
From: Ian Romanick This is the way layout(binding=xxx) works from GLSL. The old method just happened to work (and significantly predated support for layout(binding=xxx)), but future changes will break this. Signed-off-by: Ian Romanick Cc: "10.6 11.0" --- src/mesa/main/ff_fragment_shader.cpp

[Mesa-dev] [PATCH 4/9] glsl: Use constant_initializer instead of constant_value to determine whether to keep an unused uniform

2015-10-09 Thread Ian Romanick
From: Ian Romanick This even matches the comment "uniform initializers are precious, and could get used by another stage." Signed-off-by: Ian Romanick Cc: "10.6 11.0" --- src/glsl/opt_dead_code.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/opt_dead_code.cpp

[Mesa-dev] [PATCH 9/9] glsl: Never allow the sequence operator anywhere in an array size

2015-10-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index f34cbe0..a21f25c 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -2069,7 +

[Mesa-dev] [PATCH 7/9] glsl: Add method to determine whether an expression contains the sequence operator

2015-10-09 Thread Ian Romanick
From: Ian Romanick This will be used in the next patch to enforce some language sematics. v2: Fix inverted logic in ast_function_expression::has_sequence_subexpression. The method originally had a different name and a different meaning. I fixed the logic in ast_to_hir.cpp, but I only changed t

[Mesa-dev] [PATCH 8/9] glsl: In later GLSL versions, sequence operator is cannot be a constant expression

2015-10-09 Thread Ian Romanick
From: Ian Romanick Fixes: ES3-CTS.shaders.negative.constant_sequence spec/glsl-es-3.00/compiler/global-initializer/from-sequence.vert spec/glsl-es-3.00/compiler/global-initializer/from-sequence.frag Signed-off-by: Ian Romanick Cc: "10.6 11.0" --- src/glsl/ast_to_hir.cpp | 43

[Mesa-dev] [PATCH 5/9] glsl: Only set ir_variable::constant_value for const-decorated variables

2015-10-09 Thread Ian Romanick
From: Ian Romanick Right now we're also setting for uniforms, and that doesn't seem to hurt things. The next patch will make general global variables in GLSL ES, and those definitely should not have constant_value set! Signed-off-by: Ian Romanick Cc: "10.6 11.0" --- src/glsl/ast_to_hir.cpp |

Re: [Mesa-dev] [PATCH] glsl: couple shader_enums cleanups

2015-10-09 Thread Rob Clark
On Fri, Oct 9, 2015 at 8:07 PM, Emil Velikov wrote: > On 9 October 2015 at 23:27, Rob Clark wrote: >> On Fri, Oct 9, 2015 at 5:57 PM, Emil Velikov >> wrote: >>> On 9 October 2015 at 21:31, Rob Clark wrote: From: Rob Clark Add missing enum to gl_system_value_name() and move VARY

Re: [Mesa-dev] [PATCH] mesa/glformats: Undo code changes from _mesa_base_tex_format() move

2015-10-09 Thread Matt Turner
On Fri, Oct 9, 2015 at 3:26 PM, Nanley Chery wrote: > From: Nanley Chery > > The refactoring commit, c6bf1cd, accidentally reverted cd49b97 > and 99b1f47. These changes caused more code to be added to the > function and removed the existing support for ASTC. This patch > reverts those modificatio

Re: [Mesa-dev] [PATCH] glsl: couple shader_enums cleanups

2015-10-09 Thread Emil Velikov
On 9 October 2015 at 23:27, Rob Clark wrote: > On Fri, Oct 9, 2015 at 5:57 PM, Emil Velikov wrote: >> On 9 October 2015 at 21:31, Rob Clark wrote: >>> From: Rob Clark >>> >>> Add missing enum to gl_system_value_name() and move VARYING_SLOT_MAX / >>> FRAG_RESULT_MAX / etc into shader_enums.h as

[Mesa-dev] [PATCH] mesa/glformats: Undo code changes from _mesa_base_tex_format() move

2015-10-09 Thread Nanley Chery
From: Nanley Chery The refactoring commit, c6bf1cd, accidentally reverted cd49b97 and 99b1f47. These changes caused more code to be added to the function and removed the existing support for ASTC. This patch reverts those modifications. v2. Actually include ASTC support again. Bugzilla: https:/

Re: [Mesa-dev] [PATCH] glsl: couple shader_enums cleanups

2015-10-09 Thread Rob Clark
On Fri, Oct 9, 2015 at 5:57 PM, Emil Velikov wrote: > On 9 October 2015 at 21:31, Rob Clark wrote: >> From: Rob Clark >> >> Add missing enum to gl_system_value_name() and move VARYING_SLOT_MAX / >> FRAG_RESULT_MAX / etc into shader_enums.h as suggested by Emil. >> >> Reported-by: Emil Velikov >

[Mesa-dev] [PATCH] mesa/glformats: Undo code changes from _mesa_base_tex_format() move

2015-10-09 Thread Nanley Chery
From: Nanley Chery The refactoring commit, c6bf1cd, accidentally reverted cd49b97 and 99b1f47. These changes caused more code to be added to the function and removed the existing support for ASTC. This patch reverts those modifications. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=9222

Re: [Mesa-dev] [PATCH] u_vbuf: fix vb slot assignment for translated buffers

2015-10-09 Thread Marek Olšák
Do you still have commit access and should somebody else push this? Marek On Sun, Oct 4, 2015 at 2:19 PM, Marek Olšák wrote: > Oh, I forgot this: > > Reviewed-by: Marek Olšák > > Marek > > On Sun, Oct 4, 2015 at 2:03 PM, Marek Olšák wrote: >> Nice catch. Please add this to the commit message:

Re: [Mesa-dev] [PATCH] glsl: couple shader_enums cleanups

2015-10-09 Thread Emil Velikov
On 9 October 2015 at 21:31, Rob Clark wrote: > From: Rob Clark > > Add missing enum to gl_system_value_name() and move VARYING_SLOT_MAX / > FRAG_RESULT_MAX / etc into shader_enums.h as suggested by Emil. > > Reported-by: Emil Velikov > Signed-off-by: Rob Clark > --- > Note: punted on the STATIC

Re: [Mesa-dev] [PATCH 4/4] program: remove _mesa_init_*_program wrappers

2015-10-09 Thread Emil Velikov
On 9 October 2015 at 18:38, Marek Olšák wrote: > On Fri, Oct 9, 2015 at 7:33 PM, Emil Velikov wrote: >> On 9 October 2015 at 17:55, Marek Olšák wrote: [snip] >>> I think GL_FRAGMENT_PROGRAM_NV is from an NV extension supported by >>> some classic drivers but not st/mesa. >>> >> Seems to be part

[Mesa-dev] [PATCH] glsl: couple shader_enums cleanups

2015-10-09 Thread Rob Clark
From: Rob Clark Add missing enum to gl_system_value_name() and move VARYING_SLOT_MAX / FRAG_RESULT_MAX / etc into shader_enums.h as suggested by Emil. Reported-by: Emil Velikov Signed-off-by: Rob Clark --- Note: punted on the STATIC_ASSERT() thing for now.. kinda wanted some- think more like

[Mesa-dev] [Bug 92371] [HSW]deqp-gles2 Functional@shaders@constant_expressions@ sutests are failing 432 of 462 available tests

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92371 Matt Turner changed: What|Removed |Added Component|Mesa core |Drivers/DRI/i965 Assignee|mesa-d

[Mesa-dev] [Bug 92372] [HSW] deqp-gles2 functional.clipping.line/point are failing

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92372 Matt Turner changed: What|Removed |Added Component|Mesa core |Drivers/DRI/i965 Assignee|mesa-d

[Mesa-dev] [Bug 92373] [HSW] deqpl-gles2 Functional@fbo@completeness@renderable sub cases are failing

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92373 Matt Turner changed: What|Removed |Added Component|Mesa core |Drivers/DRI/i965 Assignee|mesa-d

[Mesa-dev] [Bug 92374] [HSW] deqp-gles2 functional@fbo@render@recreate_buffer are failing some tests (5)

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92374 Matt Turner changed: What|Removed |Added Component|Mesa core |Drivers/DRI/i965 Assignee|mesa-d

[Mesa-dev] [Bug 92374] [HSW] deqp-gles2 functional@fbo@render@recreate_buffer are failing some tests (5)

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92374 --- Comment #1 from Elio --- Created attachment 118790 --> https://bugs.freedesktop.org/attachment.cgi?id=118790&action=edit Terminal Output -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] [Bug 92374] [HSW] deqp-gles2 functional@fbo@render@recreate_buffer are failing some tests (5)

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92374 Bug ID: 92374 Summary: [HSW] deqp-gles2 functional@fbo@render@recreate_buffer are failing some tests (5) Product: Mesa Version: 11.0 Hardware: Other OS: All

Re: [Mesa-dev] [PATCH] glsl: move shader_enums into nir

2015-10-09 Thread Rob Clark
On Fri, Oct 9, 2015 at 4:55 AM, Emil Velikov wrote: > On 8 October 2015 at 23:25, Rob Clark wrote: >> From: Rob Clark >> >> First step towards inverting the dependency between glsl and nir (so nir >> can be used without glsl). Also solves this issue with 'make distclean' >> >> Making distclea

[Mesa-dev] [Bug 92373] [HSW] deqpl-gles2 Functional@fbo@completeness@renderable sub cases are failing

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92373 --- Comment #2 from Elio --- Adding test cases for reference (query creation for fast tracking) <% deqp-gles2@functional@fbo@completeness@renderable@renderbuffer@color0@r11f_g11f_b10f Fail new bug EditRemove deqp-gles2@functional@fbo@comple

[Mesa-dev] [Bug 92373] [HSW] deqpl-gles2 Functional@fbo@completeness@renderable sub cases are failing

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92373 --- Comment #1 from Elio --- Created attachment 118788 --> https://bugs.freedesktop.org/attachment.cgi?id=118788&action=edit Terminal Output -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] [Bug 92373] [HSW] deqpl-gles2 Functional@fbo@completeness@renderable sub cases are failing

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92373 Bug ID: 92373 Summary: [HSW] deqpl-gles2 Functional@fbo@completeness@renderable sub cases are failing Product: Mesa Version: 11.0 Hardware: Other

[Mesa-dev] [Bug 92372] [HSW] deqp-gles2 functional.clipping.line/point are failing

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92372 Bug ID: 92372 Summary: [HSW] deqp-gles2 functional.clipping.line/point are failing Product: Mesa Version: 11.0 Hardware: Other OS: All Status: N

[Mesa-dev] [Bug 92372] [HSW] deqp-gles2 functional.clipping.line/point are failing

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92372 --- Comment #1 from Elio --- Created attachment 118785 --> https://bugs.freedesktop.org/attachment.cgi?id=118785&action=edit Terminal Output -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

Re: [Mesa-dev] [PATCH] mesa: Remove GL_ARB_sampler_object depth compare error checking.

2015-10-09 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Am 2015-10-06 um 21:01 schrieb Brian Paul: > Thanks for reposting. Look OK to me. I'll commit it later. I see it is in. Thanks for taking care of this! Cheers, Stefan -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQIcBAEBCAAGBQJWGAY+AAoJEN0/Y

Re: [Mesa-dev] New stable-branch 11.0 candidate pushed

2015-10-09 Thread Ilia Mirkin
On Thu, Oct 8, 2015 at 5:50 AM, Emil Velikov wrote: > Ilia Mirkin (6): > nouveau: make sure there's always room to emit a fence Please remove this one from your list of cherry-picked patches. While it fixes real issues on nv30 (and probably the other generations too), it appears to introduc

[Mesa-dev] [Bug 92371] [HSW]deqp-gles2 Functional@shaders@constant_expressions@ sutests are failing 432 of 462 available tests

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92371 --- Comment #2 from Elio --- Adding test cases : <% deqp-gles2@functional@shaders@builtin_variable@max_draw_buffers_fragment Fail deqp-gles2@functional@shaders@builtin_variable@max_draw_buffers_vertex Fail deqp-gles2@functional@s

[Mesa-dev] [Bug 92371] [HSW]deqp-gles2 Functional@shaders@constant_expressions@ sutests are failing 432 of 462 available tests

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92371 --- Comment #1 from Elio --- Created attachment 118782 --> https://bugs.freedesktop.org/attachment.cgi?id=118782&action=edit Terminal Output -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] [Bug 92371] [HSW]deqp-gles2 Functional@shaders@constant_expressions@ sutests are failing 432 of 462 available tests

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92371 Bug ID: 92371 Summary: [HSW]deqp-gles2 Functional@shaders@constant_expressions@ sutests are failing 432 of 462 available tests Product: Mesa Version: 11.0

Re: [Mesa-dev] [PATCH 4/4] program: remove _mesa_init_*_program wrappers

2015-10-09 Thread Matt Turner
On Fri, Oct 9, 2015 at 10:38 AM, Marek Olšák wrote: > On Fri, Oct 9, 2015 at 7:33 PM, Emil Velikov wrote: >> On 9 October 2015 at 17:55, Marek Olšák wrote: >>> On Thu, Oct 8, 2015 at 3:49 PM, Emil Velikov >>> wrote: On 8 October 2015 at 01:12, Marek Olšák wrote: > From: Marek Olšák

Re: [Mesa-dev] [PATCH 4/4] program: remove _mesa_init_*_program wrappers

2015-10-09 Thread Marek Olšák
On Fri, Oct 9, 2015 at 7:33 PM, Emil Velikov wrote: > On 9 October 2015 at 17:55, Marek Olšák wrote: >> On Thu, Oct 8, 2015 at 3:49 PM, Emil Velikov >> wrote: >>> On 8 October 2015 at 01:12, Marek Olšák wrote: From: Marek Olšák They didn't do anything useful. --- src

Re: [Mesa-dev] [PATCH 2/2] glsl: include variable name in error messages about initializers

2015-10-09 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] glsl: shader outputs cannot have initializers

2015-10-09 Thread Matt Turner
On Wed, Oct 7, 2015 at 1:12 AM, Iago Toral Quiroga wrote: > GLSL Spec 4.20.8, 4.3 Storage Qualifiers: > > "Initializers in global declarations may only be used in declarations of > global variables with no storage qualifier, with a const qualifier or > with a uniform qualifier." > > We do this f

Re: [Mesa-dev] [PATCH 4/4] program: remove _mesa_init_*_program wrappers

2015-10-09 Thread Emil Velikov
On 9 October 2015 at 17:55, Marek Olšák wrote: > On Thu, Oct 8, 2015 at 3:49 PM, Emil Velikov wrote: >> On 8 October 2015 at 01:12, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> They didn't do anything useful. >>> --- >>> src/mesa/drivers/dri/i915/i915_fragprog.c | 7 +- >>> src/

Re: [Mesa-dev] [PATCH shader-db 1/2] report.py: rework and update for cycle info

2015-10-09 Thread Matt Turner
On Fri, Oct 2, 2015 at 2:37 PM, Connor Abbott wrote: > Now that we have three separate things we want to measure (instructions, > cycles, and loops), it's impractical to keep adding special code for > changes in each thing. Instead, for each program in before and after we > store a table of measur

Re: [Mesa-dev] [PATCH 2/3] nir/prog: Use nir_foreach_variable

2015-10-09 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] i965: Turn UBOs as push constants

2015-10-09 Thread Ben Widawsky
On Fri, Oct 09, 2015 at 06:06:30PM +0300, Abdiel Janulgue wrote: > Ping! No thoughts/consensus if this approach is worth considering or > not? The patches are getting stale. Should I re-base or just discard > these optimisations? > I am not the right person to ask, but I think it's certainly wort

Re: [Mesa-dev] [PATCH 4/4] program: remove _mesa_init_*_program wrappers

2015-10-09 Thread Marek Olšák
On Thu, Oct 8, 2015 at 3:49 PM, Emil Velikov wrote: > On 8 October 2015 at 01:12, Marek Olšák wrote: >> From: Marek Olšák >> >> They didn't do anything useful. >> --- >> src/mesa/drivers/dri/i915/i915_fragprog.c | 7 +- >> src/mesa/drivers/dri/i965/brw_program.c| 10 +- >

[Mesa-dev] [Bug 92368] [BSW] Regression: glx@glx_arb_sync_control@timing -fullscreen test Fail

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92368 Rami changed: What|Removed |Added Summary|[BSW] Regression: |[BSW] Regression: |glx@glx_arb_

[Mesa-dev] [Bug 92368] [BSW] Regression: glx@glx_arb_sync_control@timing -fullscreen -diviso test Fail

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92368 Bug ID: 92368 Summary: [BSW] Regression: glx@glx_arb_sync_control@timing -fullscreen -diviso test Fail Product: Mesa Version: 11.0 Hardware: Other OS: Linux

Re: [Mesa-dev] [PATCH] i965/gen8: Remove gen<8 checks in gen8 code

2015-10-09 Thread Anuj Phogat
On Thu, Oct 8, 2015 at 12:21 PM, Chad Versace wrote: > Some assertions in gen8_surface_state.c checked for gen < 8. > --- > src/mesa/drivers/dri/i965/gen8_surface_state.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.

[Mesa-dev] [Bug 92366] [BSW] Regression: glx@glx-swap-event_async failed

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92366 Rami changed: What|Removed |Added Summary|BSW] Regression:|[BSW] Regression: |glx@glx-swap

[Mesa-dev] [Bug 92366] BSW] Regression: glx@glx-swap-event_async failed

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92366 Bug ID: 92366 Summary: BSW] Regression: glx@glx-swap-event_async failed Product: Mesa Version: 11.0 Hardware: Other OS: Linux (All) Status: NEW Severity:

Re: [Mesa-dev] [PATCH] mesa: use gl_shader_variable in program resource list WIP

2015-10-09 Thread Marek Olšák
Hi, I like the idea. I started working on this too, but stopped because of other things: http://cgit.freedesktop.org/~mareko/mesa/commit/?id=d5266d5c22ba798c105b95c8f227faf8f04718af Marek On Fri, Oct 9, 2015 at 7:57 AM, Tapani Pälli wrote: > Patch changes linker to allocate gl_shader_variable i

[Mesa-dev] [Bug 92361] [BSW] Regression: glx@glx-copy-sub-buffer failed

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92361 Bug ID: 92361 Summary: [BSW] Regression: glx@glx-copy-sub-buffer failed Product: Mesa Version: 11.0 Hardware: Other OS: Linux (All) Status: NEW Severity:

Re: [Mesa-dev] [RFC] Vendor-neutral dispatch library for OpenGL

2015-10-09 Thread Kyle Brenneman
On 10/08/2015 08:44 PM, Michel Dänzer wrote: On 07.10.2015 04:58, Kyle Brenneman wrote: On 10/06/2015 12:43 PM, Emil Velikov wrote: On 6 October 2015 at 16:39, Kyle Brenneman wrote: On 10/06/2015 07:34 AM, Emil Velikov wrote: * The existing x11glvnd extension seems to be a "xserver only"

Re: [Mesa-dev] [PATCH shader-db 1/2] report.py: rework and update for cycle info

2015-10-09 Thread Erik Faye-Lund
On Fri, Oct 2, 2015 at 11:37 PM, Connor Abbott wrote: > Now that we have three separate things we want to measure (instructions, > cycles, and loops), it's impractical to keep adding special code for > changes in each thing. Instead, for each program in before and after we > store a table of measu

Re: [Mesa-dev] i965: Turn UBOs as push constants

2015-10-09 Thread Abdiel Janulgue
Ping! No thoughts/consensus if this approach is worth considering or not? The patches are getting stale. Should I re-base or just discard these optimisations? On 09/15/2015 08:59 PM, Ben Widawsky wrote: > On Tue, Sep 15, 2015 at 12:24:00PM +0300, Abdiel Janulgue wrote: >> Here's a more comprehensi

[Mesa-dev] [PATCH] nir/glsl: Use shader_prog->Name for naming the NIR shader

2015-10-09 Thread Jason Ekstrand
This has the better name to use. Aparently, sh->Name is usually 0. --- src/glsl/nir/glsl_to_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 6e1dd84..3284bdc 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++ b

Re: [Mesa-dev] [PATCH 1/3] nir/glsl: Delete dead function handling code

2015-10-09 Thread Jason Ekstrand
Scratch this patch. Not all of that code is dead, just the part where we add the return variable. On Fri, Oct 9, 2015 at 7:09 AM, Jason Ekstrand wrote: > --- > src/glsl/nir/glsl_to_nir.cpp | 39 +-- > 1 file changed, 1 insertion(+), 38 deletions(-) > > diff -

[Mesa-dev] [PATCH 1/3] nir/glsl: Delete dead function handling code

2015-10-09 Thread Jason Ekstrand
--- src/glsl/nir/glsl_to_nir.cpp | 39 +-- 1 file changed, 1 insertion(+), 38 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index efaa73e..874e361 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++ b/src/glsl/nir/glsl_to_nir.c

[Mesa-dev] [PATCH 2/3] nir/prog: Use nir_foreach_variable

2015-10-09 Thread Jason Ekstrand
--- src/mesa/program/prog_to_nir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c index fc00534..d9b1854 100644 --- a/src/mesa/program/prog_to_nir.c +++ b/src/mesa/program/prog_to_nir.c @@ -923,7 +923,7 @@ ptn_add

[Mesa-dev] [PATCH 3/3] nir: Add helpers for creating variables and adding them to lists

2015-10-09 Thread Jason Ekstrand
--- src/glsl/nir/glsl_to_nir.cpp | 40 - src/glsl/nir/nir.c | 66 ++ src/glsl/nir/nir.h | 20 + src/mesa/program/prog_to_nir.c | 19 +--- 4 files changed, 99 insertions(+), 46 deletions(-)

[Mesa-dev] [PATCH] configure.ac: ensure RM is set

2015-10-09 Thread Jonathan Gray
GNU make predefines RM to rm -f but this is not required by POSIX so ensure that RM is set. This fixes "make clean" on OpenBSD. Signed-off-by: Jonathan Gray CC: "10.6 11.0" --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index e032d77..9ba25a

Re: [Mesa-dev] [PATCH 0/4] Implement separate index spaces for UBOs and SSBOs

2015-10-09 Thread Iago Toral
On Fri, 2015-10-09 at 15:23 +0200, Iago Toral Quiroga wrote: > See the rationale for this in [1], no piglit regressions observed in my > IvyBridge laptop. > > Patch 1: Renames {Num}UniformBlocks to {Num}BufferInterfaceBlocks. This is > more consistent with the current implementation, since right n

[Mesa-dev] [PATCH 2/4] mesa: Add {Num}UniformBlocks and {Num}ShaderStorageBlocks to gl_shader{_program}

2015-10-09 Thread Iago Toral Quiroga
These arrays provide backends with separate index spaces for UBOS and SSBOs. --- src/glsl/linker.cpp | 61 + src/glsl/standalone_scaffolding.cpp | 9 ++ src/mesa/main/mtypes.h | 49 - 3 files changed,

[Mesa-dev] [PATCH 1/4] mesa: Rename {Num}UniformBlocks to {Num}BufferInterfaceBlocks

2015-10-09 Thread Iago Toral Quiroga
Currently, these arrays in gl_shader and gl_shader_program hold both UBOs and SSBOs, so this looks like a better name. We were already using NumBufferInterfaceBlocks in gl_shader_program, so this makes things more consistent as well. In a later patch we will add {Num}UniformBlocks and {Num}ShaderS

[Mesa-dev] [PATCH 4/4] i965: Adapt SSBOs to work with their own separate index space

2015-10-09 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_context.h | 4 +- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 24 +++ src/mesa/drivers/dri/i965/brw_shader.cpp | 9 ++- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 24 +++ src/mesa/drivers/dri/i965/brw_wm_surface_state.c |

[Mesa-dev] [PATCH 0/4] Implement separate index spaces for UBOs and SSBOs

2015-10-09 Thread Iago Toral Quiroga
See the rationale for this in [1], no piglit regressions observed in my IvyBridge laptop. Patch 1: Renames {Num}UniformBlocks to {Num}BufferInterfaceBlocks. This is more consistent with the current implementation, since right now UniformBlocks contains both UBOs and SSBOs. Patch 2: Adds separate

[Mesa-dev] [PATCH 3/4] glsl/lower_ubo_reference: lower UBOs and SSBOs to separate index spaces

2015-10-09 Thread Iago Toral Quiroga
--- src/glsl/lower_ubo_reference.cpp | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp index 338e21b..c00dc8e 100644 --- a/src/glsl/lower_ubo_reference.cpp +++ b/src/glsl/lower_ubo_referen

Re: [Mesa-dev] [PATCH 06/17] nir/info: Add a few bits of info for fragment shaders

2015-10-09 Thread Jason Ekstrand
On Thu, Oct 8, 2015 at 5:22 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/glsl_to_nir.cpp | 9 + > src/glsl/nir/nir.h | 13 + > src/mesa/program/prog_to_nir.c | 6 ++ > 3 files changed, 28 insertions(+) > > diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/g

[Mesa-dev] [PATCH] nvc0: fix wrong value for NVC8_COMPUTE_CLASS

2015-10-09 Thread Samuel Pitoiset
Compute class value for GF110+ is 0x91c0 and not 0x92c0. This fixes compute support and MP performance counters on GF110. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nv_object.xml.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau

Re: [Mesa-dev] [PATCH 06/17] nir/info: Add a few bits of info for fragment shaders

2015-10-09 Thread Jason Ekstrand
On Fri, Oct 9, 2015 at 6:04 AM, Pohjolainen, Topi wrote: > On Fri, Oct 09, 2015 at 05:58:41AM -0700, Jason Ekstrand wrote: >> On Fri, Oct 9, 2015 at 12:15 AM, Pohjolainen, Topi >> wrote: >> > On Thu, Oct 08, 2015 at 05:22:38PM -0700, Jason Ekstrand wrote: >> >> --- >> >> src/glsl/nir/glsl_to_nir

Re: [Mesa-dev] [PATCH 06/17] nir/info: Add a few bits of info for fragment shaders

2015-10-09 Thread Pohjolainen, Topi
On Fri, Oct 09, 2015 at 05:58:41AM -0700, Jason Ekstrand wrote: > On Fri, Oct 9, 2015 at 12:15 AM, Pohjolainen, Topi > wrote: > > On Thu, Oct 08, 2015 at 05:22:38PM -0700, Jason Ekstrand wrote: > >> --- > >> src/glsl/nir/glsl_to_nir.cpp | 9 + > >> src/glsl/nir/nir.h | 13 +

Re: [Mesa-dev] [PATCH 10/17] i965/vs: Move use_legacy_snorm_formula into the shader key

2015-10-09 Thread Jason Ekstrand
On Fri, Oct 9, 2015 at 5:58 AM, Pohjolainen, Topi wrote: > On Fri, Oct 09, 2015 at 05:53:43AM -0700, Jason Ekstrand wrote: >> On Fri, Oct 9, 2015 at 12:00 AM, Pohjolainen, Topi >> wrote: >> > On Thu, Oct 08, 2015 at 05:22:42PM -0700, Jason Ekstrand wrote: >> >> This is really an input into the sh

Re: [Mesa-dev] [PATCH 10/17] i965/vs: Move use_legacy_snorm_formula into the shader key

2015-10-09 Thread Pohjolainen, Topi
On Fri, Oct 09, 2015 at 05:53:43AM -0700, Jason Ekstrand wrote: > On Fri, Oct 9, 2015 at 12:00 AM, Pohjolainen, Topi > wrote: > > On Thu, Oct 08, 2015 at 05:22:42PM -0700, Jason Ekstrand wrote: > >> This is really an input into the shader compiler so it kind of makes sense > >> in the key. Also,

Re: [Mesa-dev] [PATCH 06/17] nir/info: Add a few bits of info for fragment shaders

2015-10-09 Thread Jason Ekstrand
On Fri, Oct 9, 2015 at 12:15 AM, Pohjolainen, Topi wrote: > On Thu, Oct 08, 2015 at 05:22:38PM -0700, Jason Ekstrand wrote: >> --- >> src/glsl/nir/glsl_to_nir.cpp | 9 + >> src/glsl/nir/nir.h | 13 + >> src/mesa/program/prog_to_nir.c | 6 ++ >> 3 files chan

Re: [Mesa-dev] [PATCH 10/17] i965/vs: Move use_legacy_snorm_formula into the shader key

2015-10-09 Thread Jason Ekstrand
On Fri, Oct 9, 2015 at 12:00 AM, Pohjolainen, Topi wrote: > On Thu, Oct 08, 2015 at 05:22:42PM -0700, Jason Ekstrand wrote: >> This is really an input into the shader compiler so it kind of makes sense >> in the key. Also, given where it's placed into the key, it doesn't >> actually make it any b

Re: [Mesa-dev] [PATCH 15/17] i965/fs: Move some of the prog_data setup into brw_wm_emit

2015-10-09 Thread Jason Ekstrand
On Fri, Oct 9, 2015 at 12:10 AM, Pohjolainen, Topi wrote: > On Thu, Oct 08, 2015 at 05:22:47PM -0700, Jason Ekstrand wrote: >> This commit moves the common/modern stuff. Some legacy stuff such as >> setting use_alt_mode was left because it needs to know whether or not we're >> an ARB program. >>

Re: [Mesa-dev] [PATCH v5] i965/fs: Handle non-const sample number in interpolateAtSample

2015-10-09 Thread Francisco Jerez
Neil Roberts writes: > If a non-const sample number is given to interpolateAtSample it will > now generate an indirect send message with the sample ID similar to > how non-const sampler array indexing works. Previously non-const > values were ignored and instead it ended up using a constant 0 val

[Mesa-dev] [Bug 92020] wglCreatePbufferARB handle attrib error

2015-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92020 zeif <332447...@qq.com> changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving

Re: [Mesa-dev] [PATCH v3 4/7] nir: add an instruction set API

2015-10-09 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Thu, Oct 8, 2015 at 9:46 PM, Connor Abbott wrote: > This will replace direct usage of nir_instrs_equal() in the CSE pass, > which reduces an O(n^2) algorithm with an effectively O(n) one. It'll > also be useful for implementing GVN on top of GCM. > > v2: > - Add te

[Mesa-dev] [PATCH v5] i965/fs: Handle non-const sample number in interpolateAtSample

2015-10-09 Thread Neil Roberts
If a non-const sample number is given to interpolateAtSample it will now generate an indirect send message with the sample ID similar to how non-const sampler array indexing works. Previously non-const values were ignored and instead it ended up using a constant 0 value. The generator will try to

Re: [Mesa-dev] [PATCH V7 03/24] glsl: allow AoA to be sized by initializer or constructor

2015-10-09 Thread Samuel Iglesias Gonsálvez
On 09/10/15 13:25, Timothy Arceri wrote: > On Thu, 2015-10-08 at 11:08 +0200, Samuel Iglesias Gonsálvez wrote: >> On 07/10/15 00:47, Timothy Arceri wrote: >>> From Section 4.1.9 of the GLSL ES 3.10 spec: >>> >>> "Arrays are sized either at compile-time or at run-time. >>> To size an array at c

Re: [Mesa-dev] [PATCH 07/12] i965: Use util_next_power_of_two() for brw_get_scratch_size()

2015-10-09 Thread Francisco Jerez
Kristian Høgsberg Kristensen writes: > This function computes the next power of two, but at least 1024. We can > do that by bitwise or'ing in 1023 and calling util_next_power_of_two(). > > We use brw_get_scratch_size() from the compiler so we need it out of > brw_program.c. We could move it to br

Re: [Mesa-dev] [PATCH V7 03/24] glsl: allow AoA to be sized by initializer or constructor

2015-10-09 Thread Timothy Arceri
On Thu, 2015-10-08 at 11:08 +0200, Samuel Iglesias Gonsálvez wrote: > On 07/10/15 00:47, Timothy Arceri wrote: > > From Section 4.1.9 of the GLSL ES 3.10 spec: > > > > "Arrays are sized either at compile-time or at run-time. > > To size an array at compile-time, either the size > > must be sp

Re: [Mesa-dev] [PATCH v2 2/5] i965/fs: move the fs_reg::smear() from get_timestamp() to the callers

2015-10-09 Thread Emil Velikov
On 9 October 2015 at 11:17, Emil Velikov wrote: > We're about to reuse get_timestamp() for the nir_intrinsic_shader_clock. > The in the latter the generalisation does not apply, so move the smear() > where needed. This also makes the function analogous to the vec4 one. > > Signed-off-by: Emil Veli

[Mesa-dev] [PATCH v2 2/5] i965/fs: move the fs_reg::smear() from get_timestamp() to the callers

2015-10-09 Thread Emil Velikov
We're about to reuse get_timestamp() for the nir_intrinsic_shader_clock. The in the latter the generalisation does not apply, so move the smear() where needed. This also makes the function analogous to the vec4 one. Signed-off-by: Emil Velikov --- Whist we can safely nuke the comments now, I've

[Mesa-dev] [PATCH v2 4/6] nir: add shader_clock intrinsic

2015-10-09 Thread Emil Velikov
v2: Add flags and inline comment/description. Signed-off-by: Emil Velikov --- src/glsl/nir/glsl_to_nir.cpp | 6 ++ src/glsl/nir/nir_intrinsics.h | 8 2 files changed, 14 insertions(+) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index efaa73e..231bdbf 10

Re: [Mesa-dev] [PATCH 05/13] nir: Add a a nir_shader_info struct

2015-10-09 Thread Iago Toral
Hi Jason, On Thu, 2015-10-01 at 18:50 -0700, Jason Ekstrand wrote: > This commit also adds code to glsl_to_nir and prog_to_nir to fill it out. > --- > src/glsl/nir/glsl_to_nir.cpp | 18 ++ > src/glsl/nir/nir.c | 1 + > src/glsl/nir/nir.h | 34 ++

Re: [Mesa-dev] [PATCH] glsl: move shader_enums into nir

2015-10-09 Thread Emil Velikov
On 8 October 2015 at 23:25, Rob Clark wrote: > From: Rob Clark > > First step towards inverting the dependency between glsl and nir (so nir > can be used without glsl). Also solves this issue with 'make distclean' > > Making distclean in mesa > make[2]: Entering directory '/mnt/sdb1/Src64/Me

Re: [Mesa-dev] [PATCH 0/2] i965/gen9: Enable rep clears

2015-10-09 Thread Neil Roberts
Seems like a good idea to me. Series is Reviewed-by: Neil Roberts - Neil Chad Versace writes: > This series lives at > git://github.com/chadversary/mesa refs/tags/skl-fast-clear-v08.01 > > No Piglit regressions on: > - Skylake 0x1912 (rev 06) > - linux 4.3-rc4 > - piglit master@2b23e7

Re: [Mesa-dev] [PATCH 2/2] glsl: include variable name in error messages about initializers

2015-10-09 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On 07/10/15 10:12, Iago Toral Quiroga wrote: > Also fix style / wrong indentation along the way and make the messages > more uniform. > --- > src/glsl/ast_to_hir.cpp | 29 + > 1 file changed, 17 insertions(+), 12 deletions(-) >

  1   2   >