On 11/06/15 20:38, Jordan Justen wrote:
> On 2015-06-03 00:01:03, Iago Toral Quiroga wrote:
>> From: Samuel Iglesias Gonsalvez
>>
>> Section 4.3.7 "Buffer Variables", GLSL 4.30 spec:
>>
>> "Buffer variables may only be declared inside interface blocks
>> (section 4.3.9 “Interface Blocks”), which
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Reviewed-by: Samuel Iglesias Gonsálvez
Sam
On 12/06/15 08:51, Timothy Arceri wrote:
> Some rules are already applied this just adds the missing ones.
> --- src/glsl/ast_to_hir.cpp | 49
> +++
)) {
> +_mesa_glsl_error(&loc, state,
> + "arrays of arrays interface blocks are"
> + " not allowed");
Put the whitespace at the end of the previous line.
With that c
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Reviewed-by: Samuel Iglesias Gonsálvez
Sam
On 12/06/15 08:52, Timothy Arceri wrote:
> --- src/glsl/ast_to_hir.cpp | 45
> + 1 file changed, 45
> insertions(+)
>
> diff --git a/src/glsl/a
Reviewed-by: Samuel Iglesias Gonsálvez
Sam
On 13/06/15 09:33, Boyan Ding wrote:
> The call to dri2_x11_add_configs_for_visuals (previously
> dri2_add_configs_for_visuals) was moved downwards in commit f8c5b8a1,
> but appeared again in its original position after its rename in
> d019
On 15/06/15 13:25, Timothy Arceri wrote:
> On Wed, 2015-06-03 at 09:01 +0200, Iago Toral Quiroga wrote:
>> From: Samuel Iglesias Gonsalvez
>>
>> They only can be defined in the last position of the shader
>> storage blocks.
>>
>> When an unsized array is used in different shaders, it might be
>>
Reviewed-by: Samuel Iglesias Gonsálvez
Sam
On 15/06/15 13:06, Timothy Arceri wrote:
> This reverts commit adee54f8269c5e9f4fde91d19f0e465afc8f14d8.
>
> Further down in the GLSL ES 3.10 spec it say:
>
> "If an array is declared as the last member of a shader storage block
&
On 15/06/15 16:29, Samuel Iglesias Gonsálvez wrote:
> Reviewed-by: Samuel Iglesias Gonsálvez
>
> Sam
>
> On 15/06/15 13:06, Timothy Arceri wrote:
>> This reverts commit adee54f8269c5e9f4fde91d19f0e465afc8f14d8.
>>
>> Further down in the GLSL ES 3.10 spec it sa
On 17/06/15 00:20, Jordan Justen wrote:
> On 2015-06-03 00:01:05, Iago Toral Quiroga wrote:
>> ---
>> src/mesa/main/bufferobj.c | 19 +++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
>> index c5d4ada..a528787 100644
On 17/06/15 20:56, Jordan Justen wrote:
> On 2015-06-03 00:01:08, Iago Toral Quiroga wrote:
>> ---
>> src/mesa/main/bufferobj.c | 110
>> ++
>> 1 file changed, 110 insertions(+)
>>
>> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
On 17/06/15 20:44, Jordan Justen wrote:
> On 2015-06-03 00:01:06, Iago Toral Quiroga wrote:
>> ---
>> src/mesa/main/bufferobj.c | 11 +++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
>> index a528787..0e762df 100644
>> --- a
On 17/06/15 20:47, Jordan Justen wrote:
> On 2015-06-03 00:01:07, Iago Toral Quiroga wrote:
>> ---
>> src/mesa/main/bufferobj.c | 142
>> ++
>> src/mesa/main/mtypes.h| 7 +++
>> 2 files changed, 149 insertions(+)
>>
>> diff --git a/src/mesa/main
On 17/06/15 21:19, Jordan Justen wrote:
> On 2015-06-03 00:01:11, Iago Toral Quiroga wrote:
>> Otherwise we can lose writes into the buffers backing the variables.
>> ---
>> src/glsl/opt_tree_grafting.cpp | 9 +
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/gl
On 17/06/15 21:24, Jordan Justen wrote:
> On 2015-06-03 00:01:12, Iago Toral Quiroga wrote:
>> If we kill dead assignments we lose the buffer writes.
>>
>> Also, we never kill UBO declarations even if they are never referenced
>> by the shader, they are always considered active. Although the spec
FD_DBG_GLSL120,"Temporary flag to force GLSL 120
> (rather
> than 130) on a3xx+"}, + {"glsl120", FD_DBG_GLSL120,"Temporary
> flag to
> force GLSL 1.20 (rather than 1.30) on a3xx+"}, DEBUG_NAMED_VALUE_END
> };
For the series,
Reviewed-by:
[level].depth / layer_multiplier; - } else {
> + if (!layered) {
>irb->layer_count = 1;
> + } else if (image->TexObject->NumLayers > 0) {
> + irb->layer_count = image->TexObject->NumLayers;
> + } else {
> + irb->layer_count = mt->
Reviewed-by: Samuel Iglesias Gonsálvez
Sam
On Tuesday 23 June 2015 23:17:53 Kenneth Graunke wrote:
> Suggested by Jason Ekstrand.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/glsl/nir/nir_opt_peephole_select.c | 20 ++--
> 1 file changed, 14 insertio
On 01/07/15 01:41, Jason Ekstrand wrote:
> On Fri, Jun 26, 2015 at 1:07 AM, Eduardo Lima Mitev wrote:
>> From: Samuel Iglesias Gonsalvez
>>
>> Avoid copying an overwritten swizzle, use the original values.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89580
>> Signed-off-by: Samu
On 29/06/15 09:11, Jordan Justen wrote:
> On 2015-06-24 07:36:24, Iago Toral wrote:
>> On Wed, 2015-06-24 at 15:43 +0300, Francisco Jerez wrote:
>>> AFAICT the reason why this (and many of the other changes in GLSL
>>> optimization passes) is needed is because SSBO loads have been
>>> implemented a
esa/drivers/dri/i965/intel_screen.c
> +++ b/src/mesa/drivers/dri/i965/intel_screen.c
> @@ -1330,11 +1330,6 @@ set_max_gl_versions(struct intel_screen *screen)
> }
> }
>
> -/* drop when libdrm 2.4.61 is released */
> -#ifndef I915_PARAM_REVISION
> -#define I915_PARAM_REVISION 32
On 07/07/15 21:47, Renaud Gaubert wrote:
> This is done by returning an rvalue of type void in the
> ast_function_expression::hir function instead of a void expression.
>
> This produces (in the case of the ternary) an hir with a call
> to the void returning function and an assignement of a void v
Hello Renaud,
I am going to comment a few things to improve your patch submission.
In the email subject we usually put [PATCH vN] to indicate it is the
Nth version of the patch, so the reviewers don't get confused about
which version is the more recent. You can do that by editing the .patch
file
On 10/07/15 22:47, Jordan Justen wrote:
> On 2015-07-10 03:13:44, Iago Toral Quiroga wrote:
>> From: Samuel Iglesias Gonsalvez
>>
>> Extend the existing lower_ubo_reference pass to also detect SSBO writes
>> and lower them to __intrinsic_store_ssbo intrinsics.
>>
>> Signed-off-by: Samuel Iglesia
ir_variable *const tmp = new(ctx)
> ir_variable(glsl_type::void_type,
> + "void_var",
> + ir_var_temporary);
> + instructions->push_tail(tmp);
> + value = new(ctx) ir_dereferenc
On 14/07/15 11:05, Thomas Helland wrote:
> 2015-07-14 9:46 GMT+02:00 Iago Toral Quiroga :
>> From: Samuel Iglesias Gonsalvez
>>
>> Signed-off-by: Samuel Iglesias Gonsalvez
>> ---
>> src/glsl/lower_ubo_reference.cpp | 179
>> +++
>
> ^ This is 80 characters
On 14/07/15 11:40, Iago Toral wrote:
> Hi Mike,
>
> On Tue, 2015-07-14 at 09:30 +, Mike Lothian wrote:
>> Hi Iago
>>
>>
>> Nice work, was it an oversight this wasn't enabled for GLES 3.1? Or is
>> the implementation slightly different?
>
> Good question, to be honest I don't remember right no
On 13/07/15 13:06, Samuel Iglesias Gonsálvez wrote:
> On 11/07/15 19:38, Renaud Gaubert wrote:
>> This is done by returning an rvalue of type void in the
>> ast_function_expression::hir function instead of a void expression.
>>
>> This produces (in the case of the
Reviewed-by: Samuel Iglesias Gonsálvez
On 16/07/15 17:33, Francisco Jerez wrote:
> This fixes essentially the same problem as for immediates. Registers
> of the UNIFORM file are typically accessed according to the formula:
>
> read_uniform(r, channel_index, array_index) =
>
index);
>
> - ubld.emit(SHADER_OPCODE_FIND_LIVE_CHANNEL, component(chan_index,
> 0));
> - ubld.emit(SHADER_OPCODE_BROADCAST, component(dst, 0),
> - src, component(chan_index, 0));
> + return dst;
Shouldn't it be src_reg(dst) ?
With that fixed,
*reg)
>brw_reg = byte_offset(brw_reg, reg->subreg_offset);
>break;
> case IMM:
> + assert(reg->stride == (reg->type == BRW_REGISTER_TYPE_V ||
> + reg->type == BRW_REGISTER_TYPE_UV ||
> + r
On Fri, 2015-07-17 at 16:33 +0300, Francisco Jerez wrote:
> Samuel Iglesias Gonsálvez writes:
>
> > On 16/07/15 17:33, Francisco Jerez wrote:
> >> When the width field was removed from fs_reg the BROADCAST handling
> >> code in opt_algebraic() start
Reviewed-by: Samuel Iglesias Gonsálvez
On 18/07/15 03:25, Timothy Arceri wrote:
> ---
> src/glsl/linker.cpp | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
> index b7a783c..cb679bd 100644
> --- a/src/glsl/linker
On 18/07/15 03:25, Timothy Arceri wrote:
> ---
> src/glsl/link_uniforms.cpp | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp
> index 11ae06f..2d50b9b 100644
> --- a/src/glsl/link_uniforms.cpp
> +++ b
Reviewed-by: Samuel Iglesias Gonsálvez
On 18/07/15 03:25, Timothy Arceri wrote:
> This fixes the remaining failing tests in:
> ES31-CTS.program_interface_query.uniform-types
> ---
> src/glsl/linker.cpp | 16 +---
> 1 file changed, 13 insertions(+), 3 deletions(-)
&g
Reviewed-by: Samuel Iglesias Gonsálvez
On 18/07/15 03:25, Timothy Arceri wrote:
> The type stored in gl_uniform_storage is the type of a single array
> element not the array type so size was always 1.
>
> V2: Dont validate sampler units pointing to 0
> ---
> src/mesa/main
On 18/07/15 03:25, Timothy Arceri wrote:
> V2: move single dimensionial array detection into a helper
>
s/dimensionial/dimensional
With that change,
Reviewed-by: Samuel Iglesias Gonsálvez
Sam
> Signed-off-by: Timothy Arceri
> ---
> src/glsl/ast.h | 8 +
I agree with Ilia but, as you said, it is not adding a lot of value. So
I give my R-b to either option.
Reviewed-by: Samuel Iglesias Gonsálvez
On 18/07/15 04:12, Timothy Arceri wrote:
> Yeah your right but its also used by _mesa_program_resource_prop
>
> I can move the comment but is
I have sent a new version of this patch [0] which has tessellation
shader constants setting.
Sam
[0] http://lists.freedesktop.org/archives/mesa-dev/2015-July/089561.html
On 14/07/15 09:46, Iago Toral Quiroga wrote:
> From: Samuel Iglesias Gonsalvez
>
> Signed-off-by: Samuel Iglesias Gonsalvez
I have sent a new version of this patch [0] which adds getters for
tessellation shaders' max constants.
Sam
[0] http://lists.freedesktop.org/archives/mesa-dev/2015-July/089562.html
On 14/07/15 09:46, Iago Toral Quiroga wrote:
> From: Samuel Iglesias Gonsalvez
>
> Signed-off-by: Samuel Iglesias
Series is:
Reviewed-by: Samuel Iglesias Gonsálvez
Thanks!
Sam
On 13/10/15 13:40, Tapani Pälli wrote:
> Patch moves existing calculation code from shader_query.cpp to happen
> during program resource list creation.
>
> No Piglit or CTS regressions were observed during testing.
>
On 15/10/15 05:43, Timothy Arceri wrote:
> On Fri, 2015-10-09 at 13:33 +0200, Samuel Iglesias Gonsálvez wrote:
>>
>> On 09/10/15 13:25, Timothy Arceri wrote:
>>> On Thu, 2015-10-08 at 11:08 +0200, Samuel Iglesias Gonsálvez wrote:
>>>> On 07/10/15 00:47, Timo
On 16/10/15 09:36, Iago Toral wrote:
> On Fri, 2015-10-16 at 09:10 +0200, Samuel Iglesias Gonsalvez wrote:
>> has_shader_storage_buffer_objects() returns true also if the OpenGL
>> context is 4.30 or ES 3.1.
>>
>> Previously, we were saying that all atomic*() GLSL builtin functions
>> for SSBOs w
On 19/10/15 11:10, Timothy Arceri wrote:
> On Mon, 2015-10-19 at 11:00 +0200, Samuel Iglesias Gonsalvez wrote:
>> Fixes a regression added by bb5aeb854915ba67abc56257f830d002c956439e.
>>
>> Signed-off-by: Samuel Iglesias Gonsalvez
>
> Thanks. Reviewed-by: Timothy Arceri
>
> I'm surprised this
Reviewed-by: Samuel Iglesias Gonsálvez
On 18/10/15 00:19, Timothy Arceri wrote:
> Fixes regression cased by bb5aeb854915ba67abc56257f830d002c956439e
>
> We don't care about the swizzle when building the name so just skip over it.
> ---
>
> New piglit test: http://pa
On 19/10/15 13:18, Samuel Iglesias Gonsálvez wrote:
> Reviewed-by: Samuel Iglesias Gonsálvez
>
Just one thing I forgot to say, Can you be more verbose about what it
fixes in the subject line?
"glsl: fix regression when building interface field name for SSBOs"
or something
Assuming no piglit regressions,
Reviewed-by: Samuel Iglesias Gonsálvez
Thanks!
Sam
On 17/10/15 11:51, Timothy Arceri wrote:
> This also removes the validation from the parser as it is not required
> and once arb_enhanced_layouts comes along we wont be able to do validation
> on t
Series is
Reviewed-by: Samuel Iglesias Gonsálvez
Thanks,
Sam
On 20/10/15 11:24, Tapani Pälli wrote:
> UniformRemapTable is used only for remapping user specified uniform
> locations to driver internally used ones, shader storage buffer
> variables should not utilize uniform
On 22/10/15 08:29, Timothy Arceri wrote:
> On Wed, 2015-10-21 at 12:18 +0200, Samuel Iglesias Gonsalvez wrote:
>> Commit f24e5e did not take into account arrays of named shader
>> storage blocks.
>>
>> Fixes 20 dEQP-GLES31.functional.ssbo.* tests:
>>
>> dEQP
>> -GLES31.functional.ssbo.layout.sing
On 22/10/15 13:08, Tapani Pälli wrote:
> On 10/22/2015 12:01 PM, Samuel Iglesias Gonsalvez wrote:
>> From ARB_program_query_interface spec:
>>
>> "uint GetProgramResourceIndex(uint program, enum programInterface,
>> const char *name);
>> [...]
>> If exact
On 22/10/15 13:06, Timothy Arceri wrote:
> On Thu, 2015-10-22 at 11:01 +0200, Samuel Iglesias Gonsalvez wrote:
>> From ARB_program_query_interface spec:
>>
>> "uint GetProgramResourceIndex(uint program, enum programInterface,
>>const char *name);
>> [...]
>>
On 22/10/15 13:06, Timothy Arceri wrote:
> On Thu, 2015-10-22 at 11:01 +0200, Samuel Iglesias Gonsalvez wrote:
>> From ARB_program_query_interface spec:
>>
>> "uint GetProgramResourceIndex(uint program, enum programInterface,
>>const char *name);
>> [...]
>>
On 22/10/15 13:19, Samuel Iglesias Gonsálvez wrote:
>
>
> On 22/10/15 13:08, Tapani Pälli wrote:
>> On 10/22/2015 12:01 PM, Samuel Iglesias Gonsalvez wrote:
>>> From ARB_program_query_interface spec:
>>>
>>> "uint GetProgramRe
On 23/10/15 12:11, Timothy Arceri wrote:
> On Fri, 2015-10-23 at 08:57 +0200, Samuel Iglesias Gonsalvez wrote:
>> Atomic counter variables can have a 'binding' layout modifier.
>> Unfortunately,
>> the atomic counter buffers are not sorted by binding value in
>> gl_shader_program's AtomicBuffers.
Reviewed-by: Samuel Iglesias Gonsálvez
Thanks!
Sam
On 26/10/15 10:22, Tapani Pälli wrote:
> Patch adds additional check to make sure we don't return locations for
> structures or arrays of structures.
>
> From page 79 of the OpenGL 4.2 spec:
> "A valid name cannot
On 26/10/15 11:38, Samuel Iglesias Gonsalvez wrote:
> From ARB_program_query_interface spec:
>
> "uint GetProgramResourceIndex(uint program, enum programInterface,
>const char *name);
> [...]
> If exactly matches the name string of one of the active resourc
Hello Timothy,
I don't see anything wrong with this patch but I needed to review older
emails [0] to have a better understanding of why you were using an
intra-stage index.
So, from my side, I give my R-b but with a minor change (see below):
Reviewed-by: Samuel Iglesias Gonsálvez
Mayb
Reviewed-by: Samuel Iglesias Gonsálvez
On 27/10/15 08:11, Tapani Pälli wrote:
> Fixes following failing dEQP test:
>dEQP-GLES3.functional.fbo.api.attachment_query_empty_fbo
>
> Signed-off-by: Tapani Pälli
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92
Reviewed-by: Samuel Iglesias Gonsálvez
On 27/10/15 12:55, Juha-Pekka Heikkila wrote:
> These helpers are ran for same case the same loop. Here joined
> their operation so the loop is ran just once. Also fixed
> out-of-memory condition here.
>
> v2: Make the loop simpler to read
On 28/10/15 06:53, Tapani Pälli wrote:
> On 10/27/2015 04:04 PM, Samuel Iglesias Gonsalvez wrote:
>> Commit 4565b6f did not update the basename match's check for
>> the case that string would exactly match the name of the
>> variable if the suffix "[0]" were appended to it.
>>
>> Fixes two dEQP-G
There is no opinions about this issue or reviews of the proposed patch
after one week.
This is just a reminder in case you have missed it :-)
Sam
On 21/10/15 12:23, Iago Toral wrote:
> Hi,
>
> The problem is with code like this (see brw_send_indirect_message):
>
> setup = brw_OR(p, addr, desc,
This is a reminder that this patch is still unreviewed.
Sam
On 22/10/15 11:01, Samuel Iglesias Gonsalvez wrote:
> From ARB_program_interface_query:
>
> "For the property of BUFFER_DATA_SIZE, then the implementation-dependent
> minimum total buffer object size, in basic machine units, required t
On 28/10/15 10:31, Tapani Pälli wrote:
> On 10/28/2015 09:09 AM, Samuel Iglesias Gonsálvez wrote:
>>
>> On 28/10/15 06:53, Tapani Pälli wrote:
>>> On 10/27/2015 04:04 PM, Samuel Iglesias Gonsalvez wrote:
>>>> Commit 4565b6f did not update the basename match&#
On 28/10/15 11:13, Samuel Iglesias Gonsálvez wrote:
>
>
> On 28/10/15 10:31, Tapani Pälli wrote:
>> On 10/28/2015 09:09 AM, Samuel Iglesias Gonsálvez wrote:
>>>
>>> On 28/10/15 06:53, Tapani Pälli wrote:
>>>> On 10/27/2015 04:04 PM, Samuel Iglesias
On 28/10/15 10:32, Iago Toral wrote:
> On Thu, 2015-10-22 at 11:01 +0200, Samuel Iglesias Gonsalvez wrote:
>> From ARB_program_interface_query:
>>
>> "For the property of BUFFER_DATA_SIZE, then the implementation-dependent
>> minimum total buffer object size, in basic machine units, required to
On 28/10/15 13:41, Tapani Pälli wrote:
> On 10/28/2015 12:16 PM, Samuel Iglesias Gonsálvez wrote:
>>
>> On 28/10/15 11:13, Samuel Iglesias Gonsálvez wrote:
>>>
>>> On 28/10/15 10:31, Tapani Pälli wrote:
>>>> On 10/28/2015 09:09 AM, Samuel Iglesias Gon
Reviewed-by: Samuel Iglesias Gonsálvez
On 08/11/15 23:34, Timothy Arceri wrote:
> From: Timothy Arceri
>
> Qualifiers on member variables are redundent all we need to do
> if check if it matches the stream associated with the block and
> throw an error if its not.
>
>
Reviewed-by: Samuel Iglesias Gonsálvez
On 05/11/15 12:33, Tapani Pälli wrote:
> From: Iago Toral Quiroga
>
> These have scoping rules that match the ones defined for other things such
> as variables, so we want them in the symbol table.
> ---
> src/glsl/glsl_sym
You can either move the function or add the function forward declaration.
In any case,
Reviewed-by: Samuel Iglesias Gonsálvez
Sam
On 05/11/15 12:33, Tapani Pälli wrote:
> From: Iago Toral Quiroga
>
> We will need this to build later patches
> ---
> src/glsl/ast_
Reviewed-by: Samuel Iglesias Gonsálvez
On 05/11/15 12:33, Tapani Pälli wrote:
> From: Iago Toral Quiroga
>
> Notice that the spec requires that a default precision has been set for every
> type used by a shader that can use a precision qualifier and does not have a
> prede
Reviewed-by: Samuel Iglesias Gonsálvez
On 06/11/15 13:03, Tapani Pälli wrote:
> From: Iago Toral Quiroga
>
> We will need this later on when we implement proper support for
> precision qualifiers in the drivers and also to do link time checks for
> uniforms as indicated by the
ned-off-by: Samuel Iglesias Gonsálvez
Cc: tapani.pa...@intel.com
---
src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
index 02b9f5b..61c9
Reviewed-by: Samuel Iglesias Gonsálvez
Are you planning to merge it to patch 5/7 or keep it standalone?
Sam
On 12/11/15 07:57, Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli
> ---
> src/glsl/ast_to_hir.cpp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gls
On 12/11/15 08:13, Tapani Pälli wrote:
>
>
> On 11/12/2015 09:11 AM, Samuel Iglesias Gonsálvez wrote:
>> Reviewed-by: Samuel Iglesias Gonsálvez
>>
>> Are you planning to merge it to patch 5/7 or keep it standalone?
>
> Yeah, I'll merge this to patch
Commit 8b28b35 added 'shared' as a keyword for compute shaders
but it broke the existing 'shared' layout qualifier support for
uniform and shader storage blocks.
This patch fixes 578 dEQP-GLES31.functional.ssbo.* tests.
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/glsl
'shared' was added in ARB_uniform_buffer_object and also used
in ARB_shader_storage_buffer_object.
A later patch will fix the shader layout qualifier regressions
in dEQP.
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/glsl/glsl_lexer.ll | 9 -
1 file changed, 8 insert
On 12/11/15 15:28, Timothy Arceri wrote:
>
>
> On 13 November 2015 12:22:39 am AEDT, "Samuel Iglesias Gonsálvez"
> wrote:
>> 'shared' was added in ARB_uniform_buffer_object and also used
>> in ARB_shader_storage_buffer_object.
>
> Hi Samue
On 12/11/15 15:38, Timothy Arceri wrote:
>
>
> On 13 November 2015 12:22:40 am AEDT, "Samuel Iglesias Gonsálvez"
> wrote:
>> Commit 8b28b35 added 'shared' as a keyword for compute shaders
>> but it broke the existing 'shared' layout qual
er (Timothy)
- Don't remove "shared" case insensitive check (Timothy)
- Remove the clearing of shared_storage flag (Timothy)
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/glsl/glsl_parser.yy | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/glsl/glsl_parser.yy b/sr
On 12/11/15 18:45, Emil Velikov wrote:
> Hi Sam,
>
> On 12 November 2015 at 15:36, Samuel Iglesias Gonsálvez
> wrote:
>> On 12/11/15 15:28, Timothy Arceri wrote:
>>> On 13 November 2015 12:22:39 am AEDT, "Samuel Iglesias Gonsálvez"
&
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hello,
I would like to have admin permissions to Mesa and Piglit projects in
patchwork [0] to change the status of patches that are mine but they
are not assigned to me.
I saw in previous emails than just asking for it here is enough. If I
need to
On 13/11/15 13:40, Emil Velikov wrote:
> On 13 November 2015 at 12:34, Antía Puentes wrote:
>> On vie, 2015-11-13 at 13:26 +0100, Samuel Iglesias Gonsálvez wrote:
>>> Hello,
>>>
>>> I would like to have admin permissions to Mesa and Piglit projects in
>&
On 13/11/15 11:32, Tapani Pälli wrote:
> Patch adds additional mask for tracking which vertex buffer bindings
> are set. This array can be directly compared to which vertex arrays
> are enabled and should match when drawing.
>
> Fixes following CTS tests:
>
>ES31-CTS.draw_indirect.negative-
On Tuesday 10 February 2015 11:32:32 Matt Turner wrote:
> On Tue, Feb 10, 2015 at 10:52 AM, Matt Turner wrote:
> >> + /* Round floating point values to nearest integer to avoid "off by
> >> one texel" +* kind of errors when blitting.
> >> +*/
> >> + x0 = wm_push_consts.dst_x0 = dst_x0
On Wednesday 18 February 2015 15:08:19 Kenneth Graunke wrote:
> On Wednesday, February 18, 2015 12:00:39 PM Matt Turner wrote:
> > On Mon, Dec 1, 2014 at 5:04 AM, Eduardo Lima Mitev
wrote:
> > > From: Samuel Iglesias Gonsalvez
> > >
> > > Create a new search function to look for matching built-
On Wednesday 18 February 2015 12:00:39 Matt Turner wrote:
> On Mon, Dec 1, 2014 at 5:04 AM, Eduardo Lima Mitev wrote:
> > From: Samuel Iglesias Gonsalvez
> >
> > Create a new search function to look for matching built-in functions by
> > name and use it for built-in function redefinition or over
On Thursday 19 February 2015 00:59:56 Kenneth Graunke wrote:
> On Thursday, February 19, 2015 09:55:35 AM Samuel Iglesias Gonsalvez wrote:
> > Create a new search function to look for matching built-in functions by
> > name and use it for built-in function redefinition or overload in GLSL ES
> > 3.
On Wednesday 18 February 2015 11:51:45 Matt Turner wrote:
> On Tue, Dec 9, 2014 at 2:52 AM, Eduardo Lima Mitev wrote:
> > From: Samuel Iglesias Gonsalvez
> >
> > GLSL 1.50 and GLSL 4.40 specs, they both say the same in
> > "Interface Blocks" section:
> >
> > "If no optional qualifier is used in
On Thursday 19 February 2015 11:39:13 Ian Romanick wrote:
> On 12/09/2014 02:52 AM, Eduardo Lima Mitev wrote:
> > From: Samuel Iglesias Gonsalvez
> >
> > GLSL 1.50 and GLSL 4.40 specs, they both say the same in
> > "Interface Blocks" section:
> >
> > "If no optional qualifier is used in a member
On Tuesday 24 February 2015 12:22:18 Ian Romanick wrote:
> This patch is
>
> Reviewed-by: Ian Romanick
>
> Please also add the following to the commit message:
>
> Cc: "10.4 10.5"
>
> If you guys have the time, I'd also really appreciate a piglit test or
> two for this case.
>
OK, we are go
On Sun, 2015-03-01 at 12:38 +, Emil Velikov wrote:
> On 28/02/15 20:42, Matt Turner wrote:
> > On Sat, Feb 28, 2015 at 3:10 AM, Emil Velikov
> > wrote:
> >> On 27/02/15 17:42, Matt Turner wrote:
> >>> For flex and bison, we check if a generated source file exists, which
> >>> is probably a go
On Tue, 2015-03-03 at 16:50 +0100, Kai Wasserbäch wrote:
> Samuel Iglesias Gonsalvez wrote on 03.03.2015 08:56:
> > This output variables gives more flexibility for future changes
> > in autoconf to detect if it is needed to auto-generate files and
> > check for the auto-generation dependencies.
>
On Wed, 2015-03-04 at 15:35 +0100, Kai Wasserbäch wrote:
> Samuel Iglesias Gonsálvez wrote on 04.03.2015 07:54:
> > On Tue, 2015-03-03 at 16:50 +0100, Kai Wasserbäch wrote:
> >> Samuel Iglesias Gonsalvez wrote on 03.03.2015 08:56:
> >>> This output variables giv
On Mon, 2017-01-23 at 15:52 +0100, Samuel Iglesias Gonsálvez wrote:
> On Fri, 2017-01-20 at 13:41 -0800, Matt Turner wrote:
> > On Tue, Jan 17, 2017 at 1:49 AM, Samuel Iglesias Gonsálvez
> > wrote:
> > > It is tested empirically that IVB/BYT don't support indirec
enum isl_format format1,
> + enum isl_format format2)
> +{
> + /* They must support CCS_E */
> + if (!isl_format_supports_ccs_e(devinfo, format1) ||
> + !isl_format_supports_ccs_e(devinfo, format1))
s/format1/format2
With that c
Patch series is
Reviewed-by: Samuel Iglesias Gonsálvez
Just one minor comment on patch 3.
Sam
On Wed, 2017-02-01 at 14:40 -0800, Jason Ekstrand wrote:
> The term "lossless compression" could potentially mean multisample
> color compression, single-sample color compressio
Reviewed-by: Samuel Iglesias Gonsálvez
On Wed, 2017-02-01 at 17:21 -0800, Nanley Chery wrote:
> Commit 968ffd6c868af7226e8f889573eef709888151cb stored the last
> subpass
> index of all the attachments but that of the depth-stencil
> attachment.
> This could cause depth buffers u
Reviewed-by: Samuel Iglesias Gonsálvez
On Thu, 2017-02-02 at 13:14 -0800, Kenneth Graunke wrote:
> dEQP-EGL.functional.create_context.no_config tries to create a
> context
> with no config, then immediately destroys it. The drawbuffer is
> never
> set up, so we can't dere
Gentle reminder :)
Sam
On Wed, 2017-01-25 at 11:20 +0100, Samuel Iglesias Gonsálvez wrote:
> Don't lower a type conversion between different type sizes
> because SEL does't support them, SEL without conditional modifier
> just do a raw move.
>
> Signed-off-by:
Reviewed-by: Samuel Iglesias Gonsálvez
On Mon, 2017-02-06 at 21:20 -0800, Jason Ekstrand wrote:
> On Mon, Feb 6, 2017 at 9:18 PM, Jason Ekstrand
> wrote:
> > These are currently getting hit by the Skia Vulkan back-end
>
> Bugzilla: https://bugs.freedesktop.org/sho
r' is referenced later in ast_declarator_list::hir().
This patch fixes it by assigning 'earlier' to var, as this variable is
the one we keep.
This error was detected by Address Sanitizer.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99677
Signed-off-by: Samuel Iglesias Gonsálvez
---
sr
1 - 100 of 1476 matches
Mail list logo
