I agree with Ilia but, as you said, it is not adding a lot of value. So I give my R-b to either option.
Reviewed-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> On 18/07/15 04:12, Timothy Arceri wrote: > Yeah your right but its also used by _mesa_program_resource_prop > > I can move the comment but is it really adding any value anyway? > > On Fri, 2015-07-17 at 21:31 -0400, Ilia Mirkin wrote: >> The comment is misplaced, but not entirely wrong. It should be on the >> program_resource_location helper. That helper is in fact used by the >> other 2 functions >> >> On Fri, Jul 17, 2015 at 9:25 PM, Timothy Arceri <t_arc...@yahoo.com.au> >> wrote: >>> --- >>> src/mesa/main/shader_query.cpp | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/src/mesa/main/shader_query.cpp >>> b/src/mesa/main/shader_query.cpp >>> index a6246a3..0473c2e 100644 >>> --- a/src/mesa/main/shader_query.cpp >>> +++ b/src/mesa/main/shader_query.cpp >>> @@ -787,8 +787,6 @@ program_resource_location(struct gl_shader_program >>> *shProg, >>> >>> /** >>> * Function implements following location queries: >>> - * glGetAttribLocation >>> - * glGetFragDataLocation >>> * glGetUniformLocation >>> */ >>> GLint >>> -- >>> 2.4.3 >>> >>> _______________________________________________ >>> mesa-dev mailing list >>> mesa-dev@lists.freedesktop.org >>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
