On 17/06/15 21:19, Jordan Justen wrote: > On 2015-06-03 00:01:11, Iago Toral Quiroga wrote: >> Otherwise we can lose writes into the buffers backing the variables. >> --- >> src/glsl/opt_tree_grafting.cpp | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/src/glsl/opt_tree_grafting.cpp b/src/glsl/opt_tree_grafting.cpp >> index d47613c..7f2ee6c 100644 >> --- a/src/glsl/opt_tree_grafting.cpp >> +++ b/src/glsl/opt_tree_grafting.cpp >> @@ -359,10 +359,11 @@ tree_grafting_basic_block(ir_instruction *bb_first, >> if (!lhs_var) >> continue; >> >> - if (lhs_var->data.mode == ir_var_function_out || >> - lhs_var->data.mode == ir_var_function_inout || >> - lhs_var->data.mode == ir_var_shader_out) >> - continue; >> + if (lhs_var->data.mode == ir_var_function_out || >> + lhs_var->data.mode == ir_var_function_inout || >> + lhs_var->data.mode == ir_var_shader_out || >> + lhs_var->data.mode == ir_var_shader_storage) >> + continue; > > This indentation looks wrong. If fixed, > Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com> >
Actually the indentation is fine: it uses 3-spaces. The old code was mixing tabs and spaces. Thanks, Sam >> >> ir_variable_refcount_entry *entry = >> info->refs->get_variable_entry(lhs_var); >> >> -- >> 1.9.1 >> >> _______________________________________________ >> mesa-dev mailing list >> mesa-dev@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/mesa-dev > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev