xiaoxiang781216 merged PR #16499:
URL: https://github.com/apache/nuttx/pull/16499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
Donny9 commented on PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2963235865
> > > please add a commit message explaining the change
> >
> >
> > could you point out which patch need more info? @jerpelea
>
>
[4aaeb80](https://github.com/apache/nuttx
jerpelea commented on PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#issuecomment-296159
> > please add a commit message explaining the change
>
> could you point out which patch need more info? @jerpelea
https://github.com/apache/nuttx/pull/16499/commits/4aaeb8
xiaoxiang781216 commented on PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2961589925
> please add a commit message explaining the change
could you point out which patch need more info? @jerpelea
--
This is an automated message from the Apache Git Service.
Donny9 commented on PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2959482238
> please add a commit message to
[0ec77cf](https://github.com/apache/nuttx/commit/0ec77cf1375923da6208322190849597075752ad)
and change the title to tools/pynuttx: update fs.py base on new
Donny9 commented on PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2958604587
> > > Fix the race condition issues pointed out by @xiaoxiang781216 and then
this is fine to merge by me. I will not review this any longer as this is not
my code anymore.
> >
> >
Donny9 commented on PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2958601775
@jlaitine
The changes made this time are indeed quite significant, involving
modifications to the core relationship between file descriptors and file
structures. We've made over 140 a
Donny9 commented on code in PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#discussion_r2137501582
##
fs/inode/fs_files.c:
##
@@ -587,37 +621,138 @@ int file_allocate_from_tcb(FAR struct tcb_s *tcb, FAR
struct inode *inode,
#endif
}
+/
pussuw commented on PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2957958025
> > Fix the race condition issues pointed out by @xiaoxiang781216 and then
this is fine to merge by me. I will not review this any longer as this is not
my code anymore.
>
> The new
xiaoxiang781216 commented on PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2957935536
> Fix the race condition issues pointed out by @xiaoxiang781216 and then
this is fine to merge by me. I will not review this any longer as this is not
my code anymore.
The
jlaitine commented on PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2957885073
Why are the original patches, *which we tested to be working correctly*,
partially re-written in this PR, instead of pointing out if there were errors
in those in the closed PR?
I
xiaoxiang781216 commented on PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2957928622
> Why are the original patches, _which we tested to be working correctly_,
partially re-written in this PR, instead of pointing out if there were errors
in those in the closed PR?
xiaoxiang781216 commented on code in PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#discussion_r2136966092
##
fs/inode/fs_files.c:
##
@@ -587,37 +621,138 @@ int file_allocate_from_tcb(FAR struct tcb_s *tcb, FAR
struct inode *inode,
#endif
}
+/***
Donny9 commented on PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2957568329
> need update app side too:
>
> ```
> kernel/fs/cases/fs_getfilep_test.c: In function 'test_nuttx_fs_getfilep01':
> Error: kernel/fs/cases/fs_getfilep_test.c:75:9: error: implic
Donny9 commented on code in PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#discussion_r2136838430
##
fs/inode/fs_files.c:
##
@@ -258,70 +292,43 @@ static void task_fssync(FAR struct tcb_s *tcb, FAR void
*arg)
*
***
xiaoxiang781216 commented on PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2956563766
need update app side too:
```
kernel/fs/cases/fs_getfilep_test.c: In function 'test_nuttx_fs_getfilep01':
Error: kernel/fs/cases/fs_getfilep_test.c:75:9: error: implicit de
xiaoxiang781216 commented on code in PR #16499:
URL: https://github.com/apache/nuttx/pull/16499#discussion_r2136222979
##
fs/inode/fs_files.c:
##
@@ -587,37 +618,120 @@ int file_allocate_from_tcb(FAR struct tcb_s *tcb, FAR
struct inode *inode,
#endif
}
+/***
pussuw commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2956208399
> > Hi @Donny9 it is not possible to add permissions to tiiuae/nuttx, you
can push the patches to another branch and make a new PR.
>
> you don't give the full write permission of yo
pussuw closed pull request #16361: fs/vfs: Separate file descriptors from file
descriptions
URL: https://github.com/apache/nuttx/pull/16361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
xiaoxiang781216 commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2956158379
> Hi @Donny9 it is not possible to add permissions to tiiuae/nuttx, you can
push the patches to another branch and make a new PR.
you don't give the full write permission of
Donny9 commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2955578742
@pussuw
Hello, could you please grant me write permissions to your GitHub
repository? I've made updates to the code locally and need to sync them up, but
I'm currently encountering per
pussuw commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2955595803
Hi @Donny9 it is not possible to add permissions to tiiuae/nuttx, you can
push the patches to another branch and make a new PR.
--
This is an automated message from the Apache Git Servic
jlaitine commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2948240713
@xiaoxiang781216 ,
Could you elaborate a bit why can't this be integrated and further
optimizations / cleanups done on top of this? Does this patchset break
something? For me it i
pussuw commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2945176351
> > I am experiencing kernel crashes related to sockets,
sendmsg->psock_sendmsg .
> > This PR solves the issue; is this now good to be merged?
> > @Donny9 , @xiaoxiang781216 ?
>
xiaoxiang781216 commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2945015695
> I am experiencing kernel crashes related to sockets,
sendmsg->psock_sendmsg .
>
> This PR solves the issue; is this now good to be merged?
>
> @Donny9 , @xiaoxiang7
jlaitine commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2939352629
I am experiencing kernel crashes related to sockets, sendmsg->psock_sendmsg .
This PR solves the issue; is this now good to be merged?
--
This is an automated message from th
xiaoxiang781216 commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2931222990
> Is this ready for merge? I have seen crashes probably caused by file
descriptor race conditions.
@Donny9 is testing and refining the patch, the verified patchset will be
jpaali commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2929009120
Is this ready for merge? I have seen crashes probably caused by file
descriptor race conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
pussuw commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2904247947
> @pussuw please rebase this PR, i will try them on my local enviroment.
--
This is an auto
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2101941154
##
fs/inode/fs_files.c:
##
@@ -858,6 +1026,342 @@ int fs_putfilep(FAR struct file *filep)
}
#endif
+/
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2100055033
##
fs/vfs/fs_dup.c:
##
@@ -65,29 +65,32 @@ int file_dup(FAR struct file *filep, int minfd, int flags)
uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init to 0 */
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2099903455
##
fs/vfs/fs_dup.c:
##
@@ -65,29 +65,32 @@ int file_dup(FAR struct file *filep, int minfd, int flags)
uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init to 0 */
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2099685831
##
fs/vfs/fs_dup.c:
##
@@ -65,29 +65,32 @@ int file_dup(FAR struct file *filep, int minfd, int flags)
uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init to 0 */
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2099685831
##
fs/vfs/fs_dup.c:
##
@@ -65,29 +65,32 @@ int file_dup(FAR struct file *filep, int minfd, int flags)
uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init to 0 */
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2099203038
##
fs/inode/fs_files.c:
##
@@ -858,6 +1026,342 @@ int fs_putfilep(FAR struct file *filep)
}
#endif
+/
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2099170414
##
fs/inode/fs_files.c:
##
@@ -858,6 +1026,342 @@ int fs_putfilep(FAR struct file *filep)
}
#endif
+/***
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2097578555
##
fs/vfs/fs_ioctl.c:
##
@@ -39,6 +40,15 @@
* Private Functions
/
+/***
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2097578555
##
fs/vfs/fs_ioctl.c:
##
@@ -39,6 +40,15 @@
* Private Functions
/
+/***
hujun260 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2097993216
##
fs/vfs/fs_dup.c:
##
@@ -65,29 +65,32 @@ int file_dup(FAR struct file *filep, int minfd, int flags)
uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init to 0 */
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2097578555
##
fs/vfs/fs_ioctl.c:
##
@@ -39,6 +40,15 @@
* Private Functions
/
+/***
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2097578555
##
fs/vfs/fs_ioctl.c:
##
@@ -39,6 +40,15 @@
* Private Functions
/
+/***
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2097230197
##
fs/vfs/fs_dup.c:
##
@@ -65,29 +65,32 @@ int file_dup(FAR struct file *filep, int minfd, int flags)
uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2097200315
##
fs/vfs/fs_dup.c:
##
@@ -65,29 +65,32 @@ int file_dup(FAR struct file *filep, int minfd, int flags)
uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init to 0 */
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095136393
##
fs/vfs/fs_open.c:
##
@@ -372,7 +372,7 @@ int file_open(FAR struct file *filep, FAR const char *path,
int oflags, ...)
if (ret >= OK)
{
- FS_ADD_BACKTR
xiaoxiang781216 commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2891403355
> > So, I can't understand why need move fdsan/fdcheck to fcntl
>
> No need to move, the funtion nx_fcntl is just named very badly. But I'm
finally starting to undestand wha
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095922616
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
pussuw commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2891372442
> So, I can't understand why need move fdsan/fdcheck to fcntl
No need to move, the funtion nx_fcntl is just named very badly. But I'm
finally starting to undestand what you want me t
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095922616
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
xiaoxiang781216 commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2891308759
> > > I tried to modify the fcntl/ioctl calls to separate fd and file
requests. I don't think it is a good idea to modify/remove FIOC numbers.
> >
> >
> > if so, why not
pussuw commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2891276973
> > I tried to modify the fcntl/ioctl calls to separate fd and file
requests. I don't think it is a good idea to modify/remove FIOC numbers.
>
> if so, why not keep implement in nx_i
xiaoxiang781216 commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2891209631
> I tried to modify the fcntl/ioctl calls to separate fd and file requests.
I don't think it is a good idea to modify/remove FIOC numbers.
if so, why not keep implement in n
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095821342
##
fs/vfs/fs_dup.c:
##
@@ -65,29 +65,32 @@ int file_dup(FAR struct file *filep, int minfd, int flags)
uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095207463
##
fs/vfs/fs_ioctl.c:
##
@@ -43,7 +43,7 @@
* Name: file_vioctl
/
-static int file_vioct
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095591335
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFI
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095624051
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095624051
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095617002
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFI
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095597205
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFI
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095608918
##
include/nuttx/fs/ioctl.h:
##
@@ -197,8 +197,6 @@
* configuration
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095605256
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095602534
##
fs/inode/fs_files.c:
##
@@ -858,6 +1027,263 @@ int fs_putfilep(FAR struct file *filep)
}
#endif
+/
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095592349
##
fs/inode/fs_files.c:
##
@@ -858,6 +1027,263 @@ int fs_putfilep(FAR struct file *filep)
}
#endif
+/***
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095383461
##
include/nuttx/fs/ioctl.h:
##
@@ -197,8 +197,6 @@
* configuration
* OUT: N
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095515021
##
fs/vfs/fs_dup.c:
##
@@ -65,29 +65,32 @@ int file_dup(FAR struct file *filep, int minfd, int flags)
uint8_t f_tag_fdcheck; /* File owner fdcheck tag, init to 0 */
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095207463
##
fs/vfs/fs_ioctl.c:
##
@@ -43,7 +43,7 @@
* Name: file_vioctl
/
-static int file_vioct
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095207463
##
fs/vfs/fs_ioctl.c:
##
@@ -43,7 +43,7 @@
* Name: file_vioctl
/
-static int file_vioct
pussuw commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2890406654
I tried to modify the fcntl/ioctl calls to separate fd and file requests. I
don't think it is a good idea to modify/remove FIOC numbers.
--
This is an automated message from the Apache G
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095120372
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095207463
##
fs/vfs/fs_ioctl.c:
##
@@ -43,7 +43,7 @@
* Name: file_vioctl
/
-static int file_vioct
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095207463
##
fs/vfs/fs_ioctl.c:
##
@@ -43,7 +43,7 @@
* Name: file_vioctl
/
-static int file_vioct
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095136393
##
fs/vfs/fs_open.c:
##
@@ -372,7 +372,7 @@ int file_open(FAR struct file *filep, FAR const char *path,
int oflags, ...)
if (ret >= OK)
{
- FS_ADD_BACKTR
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095124199
##
include/nuttx/fs/ioctl.h:
##
@@ -197,8 +197,6 @@
* configuration
* OUT: N
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095120372
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095118825
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095112790
##
fs/inode/fs_files.c:
##
@@ -858,6 +1027,263 @@ int fs_putfilep(FAR struct file *filep)
}
#endif
+/
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2094179941
##
fs/vfs/fs_ioctl.c:
##
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFI
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2094174857
##
fs/vfs/fs_fcntl.c:
##
@@ -46,7 +46,7 @@
* Name: file_vfcntl
/
-static int f
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2094177845
##
include/nuttx/fs/fs.h:
##
@@ -466,6 +466,15 @@ struct file
off_t f_pos; /* File position */
Review Comment:
The memory leak will alwa
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2094175112
##
fs/vfs/fs_fcntl.c:
##
@@ -91,7 +91,7 @@ static int file_vfcntl(FAR struct file *filep, int cmd,
va_list ap)
*/
{
- ret = filep
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086976819
##
fs/vfs/fs_dup2.c:
##
@@ -82,29 +81,15 @@ int file_dup3(FAR struct file *filep1, FAR struct file
*filep2, int flags)
inode = filep1->f_inode;
inode_addref(inode
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086970591
##
net/local/local_sendmsg.c:
##
@@ -125,7 +125,7 @@ static int local_sendctl(FAR struct local_conn_s *conn,
goto fail;
}
- ret =
GUIDINGLI commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086926058
##
fs/vfs/fs_dup2.c:
##
@@ -82,29 +81,15 @@ int file_dup3(FAR struct file *filep1, FAR struct file
*filep2, int flags)
inode = filep1->f_inode;
inode_addref(in
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086894004
##
fs/vfs/fs_close.c:
##
@@ -134,46 +143,84 @@ int file_close_without_clear(FAR struct file *filep)
inode_release(inode);
Review Comment:
@Donn
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086872746
##
include/nuttx/fs/fs.h:
##
@@ -466,6 +466,15 @@ struct file
off_t f_pos; /* File position */
Review Comment:
refcount is required to i
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086870916
##
include/nuttx/fs/fs.h:
##
@@ -959,7 +964,7 @@ int files_duplist(FAR struct filelist *plist, FAR struct
filelist *clist,
*
**
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086869529
##
net/local/local_recvmsg.c:
##
@@ -175,7 +175,7 @@ static void local_recvctl(FAR struct local_conn_s *conn,
count = peer->lc_cfpcount;
for (i = 0; i < c
xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086867781
##
net/local/local_sendmsg.c:
##
@@ -125,7 +125,7 @@ static int local_sendctl(FAR struct local_conn_s *conn,
goto fail;
}
-
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086328589
##
include/nuttx/fs/fs.h:
##
@@ -466,6 +466,15 @@ struct file
off_t f_pos; /* File position */
Review Comment:
@anchao what is your opinion on th
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086067813
##
fs/inode/fs_files.c:
##
@@ -266,25 +402,18 @@ static void task_fssync(FAR struct tcb_s *tcb, FAR void
*arg)
*
***
pussuw commented on PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2875412623
```
nsh> fdinfo
pid:0
FD OFLAGS TYPE POS PATH BACKTRACE
0 3 10 /dev/console 0x40053878
0x400356e4 0x40038072
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086063889
##
fs/inode/fs_files.c:
##
@@ -139,26 +198,26 @@ static int files_extend(FAR struct filelist *list, size_t
row)
return -EMFILE;
}
- files = fs_heap_mallo
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086069196
##
fs/inode/fs_files.c:
##
@@ -66,61 +84,102 @@
* Name: files_fget_by_index
/
-static F
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086067813
##
fs/inode/fs_files.c:
##
@@ -266,25 +402,18 @@ static void task_fssync(FAR struct tcb_s *tcb, FAR void
*arg)
*
***
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086066759
##
fs/inode/fs_files.c:
##
@@ -246,6 +303,85 @@ static void task_fssync(FAR struct tcb_s *tcb, FAR void
*arg)
}
}
+/
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086063197
##
fs/inode/fs_files.c:
##
@@ -554,16 +663,25 @@ int file_allocate_from_tcb(FAR struct tcb_s *tcb, FAR
struct inode *inode,
{
int i = minfd / CONFIG_NFILE_DESCRIPTO
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086061232
##
include/nuttx/fs/fs.h:
##
@@ -490,20 +495,20 @@ struct file
* (file descriptor % CONFIG_NFILE_DESCRIPTORS_PER_BLOCK) as column index.
*/
-struct filelist
+struc
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086061787
##
fs/inode/fs_files.c:
##
@@ -554,16 +663,25 @@ int file_allocate_from_tcb(FAR struct tcb_s *tcb, FAR
struct inode *inode,
{
int i = minfd / CONFIG_NFILE_DESCRIPTO
Donny9 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2084821846
##
include/nuttx/fs/fs.h:
##
@@ -490,20 +495,20 @@ struct file
* (file descriptor % CONFIG_NFILE_DESCRIPTORS_PER_BLOCK) as column index.
*/
-struct filelist
+struc
pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085174457
##
include/nuttx/fs/fs.h:
##
@@ -466,6 +466,15 @@ struct file
off_t f_pos; /* File position */
Review Comment:
Yes I forgot to remove the option,
1 - 100 of 115 matches
Mail list logo
