pussuw commented on PR #16361: URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2891276973
> > I tried to modify the fcntl/ioctl calls to separate fd and file requests. I don't think it is a good idea to modify/remove FIOC numbers. > > if so, why not keep implement in nx_ioctl and call nx_ioctl not nx_fcntl in the related places? I created nx_fcntl into fs_files for two reasons: - Atomically set / get file descriptor flags, like close on exec, fdsan / fdcheck - Keep the fl_lock semantics hidden there We could re-name nx_fcntl to nx_modfdflags or something similar ? Would that be acceptable. I think nx_fcntl is now a very confusing name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
