pussuw commented on PR #16361: URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2945176351
> > I am experiencing kernel crashes related to sockets, sendmsg->psock_sendmsg . > > This PR solves the issue; is this now good to be merged? > > @Donny9 , @xiaoxiang781216 ? > > please wait a moment, because we found that mountpt_operations::dup doesn't need in the new approach and dup function need more change. @Donny9 is refining the patchset and do the internal testing. Does this have something to do with file_dup and file_dup2 (or file pointer duplication in general)? They both seem to fit very poorly into the new approach but did not know whether they can be removed or not. I also suspected that the ops::dup() is redundant but did not know for sure if some kernel component depends on it. Good that you are making a cleanup round for them, but I'd like to remind that even in its current state these patches should not break existing functionality and they fix a massive kernel side crash (for us at least). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
