xiaoxiang781216 commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2094174857
########## fs/vfs/fs_fcntl.c: ########## @@ -46,7 +46,7 @@ * Name: file_vfcntl ****************************************************************************/ -static int file_vfcntl(FAR struct file *filep, int cmd, va_list ap) +static int file_vfcntl(FAR struct file *filep, int cmd, va_list ap, int fd) Review Comment: remove fd, we should move the handle of F_DUPFD/F_DUPFD_CLOEXEC/F_GETFD/F_SETFD to fcntl/nx_fcntl and call dup/nx_dup instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
