pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086970591


##########
net/local/local_sendmsg.c:
##########
@@ -125,7 +125,7 @@ static int local_sendctl(FAR struct local_conn_s *conn,
               goto fail;
             }
 
-          ret = file_dup2(filep, filep2);
+          ret = file_dup2(filep, filep2); /* TODO: What about this ? */

Review Comment:
   That's the question I have, does file_dup have any meaning inside the kernel 
? Why do kernel drivers care about file descriptors, they are userspace stuff 
anyhow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to