xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086867781


##########
net/local/local_sendmsg.c:
##########
@@ -125,7 +125,7 @@ static int local_sendctl(FAR struct local_conn_s *conn,
               goto fail;
             }
 
-          ret = file_dup2(filep, filep2);
+          ret = file_dup2(filep, filep2); /* TODO: What about this ? */

Review Comment:
   with the new implementation, I guess that we should remove file_dupx, do you 
have any real caller inside kernel space?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to