pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095605256
##########
fs/vfs/fs_ioctl.c:
##########
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
case FIOC_SETTAG_FDSAN:
- filep->f_tag_fdsan = *(FAR uint64_t *)arg;
- ret = OK;
- break;
-
case FIOC_GETTAG_FDSAN:
- *(FAR uint64_t *)arg = filep->f_tag_fdsan;
- ret = OK;
- break;
-#endif
-
-#ifdef CONFIG_FDCHECK
case FIOC_SETTAG_FDCHECK:
- filep->f_tag_fdcheck = *(FAR uint8_t *)arg;
- ret = OK;
- break;
-
case FIOC_GETTAG_FDCHECK:
- *(FAR uint8_t *)arg = filep->f_tag_fdcheck;
- ret = OK;
+ ret = nx_fcntl(fd, req, arg);
Review Comment:
Can you suggest a better name for nx_fcntl ? What that function is trying to
do is "modify or read file descriptor flags atomically". The original name I
thought of was fs_fdcntl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
