xiaoxiang781216 commented on PR #16361: URL: https://github.com/apache/nuttx/pull/16361#issuecomment-2891403355
> > So, I can't understand why need move fdsan/fdcheck to fcntl > > No need to move, the funtion nx_fcntl is just named very badly. But I'm finally starting to undestand what you want me to do, you want me to implement the fd flag handling in nx_ioctl ? Is it OK if I move nx_ioctl into fs_files.c ? I'd still like to add the locking and hide the locks in there. Yes, this approach could reduce the change and keep the compatibility. All code which operate on the field in `struct fd` should be moved from file_xxx to nx_xxx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
