pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2086061787
##########
fs/inode/fs_files.c:
##########
@@ -554,16 +663,25 @@ int file_allocate_from_tcb(FAR struct tcb_s *tcb, FAR
struct inode *inode,
{
int i = minfd / CONFIG_NFILE_DESCRIPTORS_PER_BLOCK;
int j = minfd % CONFIG_NFILE_DESCRIPTORS_PER_BLOCK;
- FAR struct filelist *list;
+ FAR struct fdlist *list;
FAR struct file *filep;
+ FAR struct fd *fd;
irqstate_t flags;
int ret;
/* Get the file descriptor list. It should not be NULL in this context. */
list = nxsched_get_files_from_tcb(tcb);
- /* Find free file */
+ /* Allocate a new file pointer */
+
+ filep = fs_heap_malloc(sizeof(struct file));
Review Comment:
Sure, but not in the scope of this patch. It is already big enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
