pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095207463
########## fs/vfs/fs_ioctl.c: ########## @@ -43,7 +43,7 @@ * Name: file_vioctl ****************************************************************************/ -static int file_vioctl(FAR struct file *filep, int req, va_list ap) +static int file_vioctl(FAR struct file *filep, int req, va_list ap, int fd) Review Comment: ~~I'll just move them all to fcntl ? Whichever way you prefer.~~ I think this is a bad idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
