pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2095136393
##########
fs/vfs/fs_open.c:
##########
@@ -372,7 +372,7 @@ int file_open(FAR struct file *filep, FAR const char *path,
int oflags, ...)
if (ret >= OK)
{
- FS_ADD_BACKTRACE(filep);
+ FS_ADD_BACKTRACE(fdlist_fdget(nxsched_get_fdlist(), ret));
Review Comment:
file_allocate_from_tcb adds the backtrace in that branch.
I think this needs to be removed. I assumed ret == fd but it's just 0 (OK)
so this backtrace doesn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
