pussuw commented on code in PR #16361: URL: https://github.com/apache/nuttx/pull/16361#discussion_r2085174457
########## include/nuttx/fs/fs.h: ########## @@ -466,6 +466,15 @@ struct file off_t f_pos; /* File position */ Review Comment: Yes I forgot to remove the option, I'll remove it tomorrow. One option of course if we want to keep CONFIG_FS_REFCOUNT we must prevent file_close altogether, because it will never be safe to call file_close. The simplest case is stdout/stderr/stdin, now the file is shared by ALL children of init, and no duplicate file structs are created. So when a process exits, it is NOT SAFE to free stdout/stderr/stdin for that process if there is no reference counter protecting them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
