Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v17]

On Mon, 21 Oct 2024 20:46:56 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v12]

On Mon, 23 Sep 2024 17:56:39 GMT, Calvin Cheung wrote: >> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 15 commits: >> >> - Merge branch >> 'jep-483-step-02-8338018-rename-class-prelinker-to-aot-cp-resolver' into >> j

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v17]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v16]

On Tue, 15 Oct 2024 23:40:41 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v16]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v15]

On Tue, 15 Oct 2024 22:41:07 GMT, David Holmes wrote: > Still good for me - but seems to be jcheck whitespace issues. Thanks for noticing it. I've fixed the whitespaces (and need to propagate that to all subsequent PRs in this series). - PR Comment: https://git.openjdk.org/jdk/pul

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v15]

On Mon, 14 Oct 2024 07:19:03 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v15]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v14]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v13]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v12]

On Mon, 23 Sep 2024 17:07:56 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v11]

On Thu, 19 Sep 2024 05:37:17 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @dholmes-ora comments > > src/hotspot/share/cds/aotClassLinker.cpp line 122: > >> 120: assert(CDSConfig::is_dumping_aot_l

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v12]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v11]

On Thu, 19 Sep 2024 04:19:18 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v9]

On Thu, 19 Sep 2024 05:49:22 GMT, David Holmes wrote: >> Why? > > Atomic logging @stefank pointed out to me that wouldn't actually be atomic unless you used `NonInterleavingLogStream`. - PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1766216952

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v11]

On Thu, 19 Sep 2024 04:19:18 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v9]

On Thu, 19 Sep 2024 04:08:30 GMT, Ioi Lam wrote: >> src/hotspot/share/cds/aotLinkedClassBulkLoader.cpp line 170: >> >>> 168: log_error(cds)("Unable to resolve %s class from CDS archive: >>> %s", category_name, ik->external_name()); >>> 169: log_error(cds)("Expected: " INTPTR

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v8]

On Thu, 19 Sep 2024 04:01:07 GMT, Ioi Lam wrote: >> src/hotspot/share/cds/aotClassLinker.cpp line 194: >> >>> 192: if ((ik->module() == ModuleEntryTable::javabase_moduleEntry()) != >>> is_javabase) { >>> 193: continue; >>> 194: } >> >> Why do we process system loader classes (i.e

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v8]

On Thu, 19 Sep 2024 04:00:38 GMT, Ioi Lam wrote: >> src/hotspot/share/cds/aotClassLinker.cpp line 145: >> >>> 143: return false; >>> 144: } >>> 145: } >> >> Are we concerned with the possibility that we might be able to add some >> interfaces but not all, hence returning false, but

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v11]

On Thu, 19 Sep 2024 04:19:18 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v9]

On 18 Sep 2024, at 21:11, Ioi Lam wrote: > On Wed, 18 Sep 2024 05:07:33 GMT, David Holmes wrote: > … >> src/hotspot/share/cds/aotLinkedClassBulkLoader.cpp line 170: >> >>> 168: log_error(cds)("Unable to resolve %s class from CDS archive: >>> %s", category_name, ik->external_name()); >>

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v9]

On Thu, 19 Sep 2024 03:17:03 GMT, Ioi Lam wrote: >> test/hotspot/jtreg/runtime/cds/appcds/aotClassLinking/AOTClassLinkingVMOptions.java >> line 57: >> >>> 55: testCase("Archived full module graph must be enabled at >>> runtime"); >>> 56: TestCommon.run("-cp", appJar, "-Djdk.mod

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v9]

On Wed, 18 Sep 2024 05:01:00 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed ZERO build > > src/hotspot/share/cds/aotLinkedClassBulkLoader.cpp line 66: > >> 64: >> 65: void AOTLinkedClassBulkLo

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v8]

On Wed, 18 Sep 2024 01:56:36 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minor comment fix > > src/hotspot/share/cds/aotClassLinker.cpp line 212: > >> 210: } else { >> 211: const char* categ

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v8]

On Wed, 18 Sep 2024 01:59:59 GMT, David Holmes wrote: >> src/hotspot/share/cds/aotClassLinker.hpp line 60: >> >>> 58: // - The visibility of C >>> 59: // >>> 60: // During an Production Run, the JVM can use an AOTCache with an >>> AOTLinkedClassTable >> >> Suggestion: >> >> // During a Pr

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v11]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v9]

On Wed, 18 Sep 2024 05:07:33 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed ZERO build > > src/hotspot/share/cds/aotLinkedClassBulkLoader.cpp line 170: > >> 168: log_error(cds)("Unabl

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v9]

On Wed, 18 Sep 2024 05:11:48 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed ZERO build > > src/hotspot/share/cds/archiveBuilder.cpp line 316: > >> 314: >> 315: if (CDSConfig::is_dumping_aot_

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v8]

On Wed, 18 Sep 2024 01:47:26 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minor comment fix > > src/hotspot/share/cds/aotClassLinker.cpp line 121: > >> 119: assert(is_initialized(), "sanity"); >>

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v10]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v9]

On Wed, 18 Sep 2024 05:35:42 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed ZERO build > > test/hotspot/jtreg/runtime/cds/appcds/aotClassLinking/AOTClassLinkingVMOptions.java > line 57: > >> 5

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v9]

On Wed, 18 Sep 2024 05:33:09 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed ZERO build > > src/hotspot/share/classfile/systemDictionary.cpp line 139: > >> 137: if (_java_platform_loader.is_em

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v8]

On Tue, 17 Sep 2024 23:29:46 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v8]

On Wed, 18 Sep 2024 01:59:34 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minor comment fix > > src/hotspot/share/cds/aotClassLinker.hpp line 60: > >> 58: // - The visibility of C >> 59: // >>

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v9]

On Wed, 18 Sep 2024 02:57:47 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v9]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v6]

On Tue, 17 Sep 2024 19:52:29 GMT, Ashutosh Mehra wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @ashu-mehra reviews > > src/hotspot/share/runtime/threads.cpp line 322: > >> 320: universe_post_module_init(); >> 321:

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v8]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v7]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v6]

On Mon, 16 Sep 2024 21:54:49 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v6]

On Mon, 16 Sep 2024 21:54:49 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v6]

On Sat, 7 Sep 2024 00:30:34 GMT, Ioi Lam wrote: >> I've taken an initial look through but there is an awful lot to try and >> digest here. I've flagged numerous typos and minor nits. >> >> One general query: does this stuff work if the user defines their own >> initial application classloader?

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v5]

On Fri, 13 Sep 2024 16:09:25 GMT, Ashutosh Mehra wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @ashu-mehra comments > > src/hotspot/share/cds/aotClassLinker.cpp line 227: > >> 225: } >> 226: >> 227: int AOTClassLink

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v6]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v5]

On Thu, 12 Sep 2024 21:43:24 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v5]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

On Tue, 10 Sep 2024 21:31:31 GMT, Ashutosh Mehra wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @dholmes-ora comments: logging indents > > src/hotspot/share/cds/aotClassLinker.cpp line 149: > >> 147: add_candidate(i

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v4]

On Thu, 12 Sep 2024 14:04:40 GMT, Ashutosh Mehra wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @adinn comments > > test/hotspot/jtreg/runtime/cds/appcds/jvmti/ClassFileLoadHookTest.java line > 110: > >> 108:

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v4]

On Wed, 11 Sep 2024 20:26:51 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

On Tue, 10 Sep 2024 22:17:00 GMT, Ashutosh Mehra wrote: > I will continue my review tomorrow. My review is done now. - PR Comment: https://git.openjdk.org/jdk/pull/20843#issuecomment-2346553992

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

On Tue, 10 Sep 2024 10:08:35 GMT, Andrew Dinn wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @dholmes-ora comments: logging indents > > src/hotspot/share/cds/aotClassLinker.hpp line 71: > >> 69: // >> 70: class AOTCla

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v4]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

On Tue, 10 Sep 2024 00:53:32 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

On Tue, 10 Sep 2024 00:53:32 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

On Tue, 10 Sep 2024 00:53:32 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

On Tue, 10 Sep 2024 00:53:32 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

On Mon, 9 Sep 2024 05:15:20 GMT, David Holmes wrote: >> I tried to separate the "types" from the "values". I think this makes it >> easy to see how many types there are. > > Sorry I don't follow. This is just like a printf call I changed it according to your suggestion. - PR Revie

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v3]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

On Mon, 9 Sep 2024 01:01:41 GMT, Ioi Lam wrote: >> src/hotspot/share/cds/archiveBuilder.cpp line 912: >> >>> 910: >>> STATS_PARAMS(unlinked_klasses), >>> 911: boot_unlinked, >>> platform_unlinked, >>> 912:

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

On Sun, 8 Sep 2024 23:46:03 GMT, David Holmes wrote: >> I prefer boot/boot2 to make the output easier to read. Anyone debugging this >> output will need to read the code to understand what "boot2" or >> "boot-nonbase" is. A few extra characters here will not help. > > Sorry but '2' conveys zero

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

On Sun, 8 Sep 2024 23:49:45 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @dholmes-ora comments > > src/hotspot/share/cds/archiveBuilder.cpp line 912: > >> 910:

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

On Sat, 7 Sep 2024 00:30:24 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/J

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

On Fri, 6 Sep 2024 23:53:58 GMT, Ioi Lam wrote: >> src/hotspot/share/cds/archiveBuilder.cpp line 904: >> >>> 902: log_info(cds)("instance classes " STATS_FORMAT, >>> STATS_PARAMS(instance_klasses)); >>> 903: log_info(cds)(" boot " STATS_FORMAT, >>> STATS_PARAMS(boot_

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

On Fri, 6 Sep 2024 05:24:18 GMT, David Holmes wrote: > I've taken an initial look through but there is an awful lot to try and > digest here. I've flagged numerous typos and minor nits. > > One general query: does this stuff work if the user defines their own initial > application classloader?

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v2]

> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315737) and the > [CSR](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking

On Fri, 6 Sep 2024 05:10:42 GMT, David Holmes wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking

On Fri, 6 Sep 2024 05:07:09 GMT, David Holmes wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/bro

Re: RFR: 8329706: Implement -XX:+AOTClassLinking

On Fri, 6 Sep 2024 06:22:16 GMT, Alan Bateman wrote: > It is possible to run -Djava.system.class.loader=.. to set your own system > class loader, it gets created with the built-in application class loader as > its parent. In that setup you start out with 4 class loaders. Yes that is what I was

Re: RFR: 8329706: Implement -XX:+AOTClassLinking

On Fri, 6 Sep 2024 05:24:18 GMT, David Holmes wrote: > One general query: does this stuff work if the user defines their own initial > application classloader? Just to say that there isn't any support in the JDK for replacing any of the 3 built-in class loaders. In normal setup, the system cl

Re: RFR: 8329706: Implement -XX:+AOTClassLinking

On Tue, 3 Sep 2024 20:57:48 GMT, Ioi Lam wrote: > This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315

Re: RFR: 8329706: Implement -XX:+AOTClassLinking

On Tue, 3 Sep 2024 20:57:48 GMT, Ioi Lam wrote: > This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315

Re: RFR: 8329706: Implement -XX:+AOTClassLinking

On Tue, 3 Sep 2024 20:57:48 GMT, Ioi Lam wrote: > This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315

Re: RFR: 8329706: Implement -XX:+AOTClassLinking

On Tue, 3 Sep 2024 20:57:48 GMT, Ioi Lam wrote: > This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315

Re: RFR: 8329706: Implement -XX:+AOTClassLinking

On Tue, 3 Sep 2024 20:57:48 GMT, Ioi Lam wrote: > This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > **Overview** > > - A new `-XX:+AOTClassLinking` flag is added. See [JEP > 498](https://bugs.openjdk.org/browse/JDK-8315

RFR: 8329706: Implement -XX:+AOTClassLinking

This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & Linking](https://bugs.openjdk.org/browse/JDK-8315737). **Overview** - A new `-XX:+AOTClassLinking` flag is added. See [JEP 498](https://bugs.openjdk.org/browse/JDK-8315737) and the [CSR](https://bugs.openjdk.org/browse/JDK-8339506)