On Thu, 19 Sep 2024 03:17:03 GMT, Ioi Lam <ik...@openjdk.org> wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/aotClassLinking/AOTClassLinkingVMOptions.java
>> line 57:
>>
>>> 55: testCase("Archived full module graph must be enabled at
>>> runtime");
>>> 56: TestCommon.run("-cp", appJar, "-Djdk.module.validation=1",
>>> "Hello")
>>> 57: .assertAbnormalExit("CDS archive has aot-linked classes." +
>>
>> Nit: align the dots
>
> The CDS test cases indent by 4 spaces in this situation. I searched for `'^
> *[.]'` lines in the JDK source code and indentation of 8 and 4 spaces seem to
> be most common.
Method chaining has its own indentation style of aligning the dots - see all
the stream using code for example.
But just a nit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1766152229
