On Thu, 12 Sep 2024 14:04:40 GMT, Ashutosh Mehra <[email protected]> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @adinn comments
>
> test/hotspot/jtreg/runtime/cds/appcds/jvmti/ClassFileLoadHookTest.java line
> 110:
>
>> 108: "" + ClassFileLoadHook.TestCaseId.SHARING_ON_CFLH_ON);
>> 109: if (out.contains("Using AOT-linked classes: false")) {
>> 110: // We are running with VM options that do not support
>> -XX:+AOTClassLinking
>
> When will we run into this case? Is there a VM option that would silently
> disable AOTClassLinking in prod run?
AOTClassLinking requires the ability to write the full archived module graph
(FMG), so it will be disabled if jtreg is executed with
- a GC that doesn't support object heap writing, such as ZGC
- a module related option that's not compatible with FMG, such as --add-opens
I edited the comment in the test to make it clear that the JVM options affects
the writing of the archive. I also modified the log to something like this:
Using AOT-linked classes: false (static archive: no aot-linked classes)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1757622228
