On Sun, 8 Sep 2024 23:49:45 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @dholmes-ora comments > > src/hotspot/share/cds/archiveBuilder.cpp line 912: > >> 910: >> STATS_PARAMS(unlinked_klasses), >> 911: boot_unlinked, >> platform_unlinked, >> 912: app_unlinked, unreg_unlinked); > > This indentation still looks weird. Arguments on newlines should be aligned. I tried to separate the "types" from the "values". I think this makes it easy to see how many types there are. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1749426533
