On Mon, 23 Sep 2024 17:56:39 GMT, Calvin Cheung <cche...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 15 commits: >> >> - Merge branch >> 'jep-483-step-02-8338018-rename-class-prelinker-to-aot-cp-resolver' into >> jep-483-step-03-8329706-implement-xx-aot-class-linking >> - @dholmes-ora comments >> - @dholmes-ora comments >> - Fixed ZERO build >> - minor comment fix >> - @ashu-mehra comment: move code outside of call_initPhase2(); also renamed >> BOOT/BOOT2 to BOOT1/BOOT2 and refactored code related to >> AOTLinkedClassCategory >> - @ashu-mehra reviews >> - @ashu-mehra comments >> - @adinn comments >> - @dholmes-ora comments: logging indents >> - ... and 5 more: https://git.openjdk.org/jdk/compare/49dbfa6a...6029b35f > > src/hotspot/share/cds/metaspaceShared.cpp line 1536: > >> 1534: if (lsh.is_enabled()) { >> 1535: lsh.print("Using AOT-linked classes: %s (static archive: %s >> aot-linked classes", >> 1536: CDSConfig::is_using_aot_linked_classes() ? "true" : >> "false", > > Suggestion: > `BOOL_TO_STR(CDSConfig::is_using_aot_linked_classes()),` Fixed. > test/hotspot/jtreg/runtime/cds/appcds/jvmti/ClassFileLoadHookTest.java line > 100: > >> 98: TestCommon.checkExec(out); >> 99: >> 100: // JEP 483: if dumped with -XX:+AOTClassLinking, cannot use >> archive when CFLH > > Suggestion: > `..., cannot use archive when CFLH is enabled` Fixed. > test/lib/jdk/test/lib/cds/CDSAppTester.java line 50: > >> 48: public CDSAppTester(String name) { >> 49: if (CDSTestUtils.DYNAMIC_DUMP) { >> 50: throw new jtreg.SkippedException("Tests based on >> CDSAppTester should be excluded when -Dtest.dynamic.cds.archive is >> specified"); > > You could omit the `jtreg.` in the above throw statement. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1809504196 PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1809504427 PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1809504306
