On Fri, 6 Sep 2024 23:53:58 GMT, Ioi Lam <ik...@openjdk.org> wrote:
>> src/hotspot/share/cds/archiveBuilder.cpp line 904:
>>
>>> 902: log_info(cds)(" instance classes " STATS_FORMAT,
>>> STATS_PARAMS(instance_klasses));
>>> 903: log_info(cds)(" boot " STATS_FORMAT,
>>> STATS_PARAMS(boot_klasses));
>>> 904: log_info(cds)(" vm " STATS_FORMAT,
>>> STATS_PARAMS(vm_klasses));
>>
>> Suggestion:
>>
>> log_info(cds)(" vm " STATS_FORMAT,
>> STATS_PARAMS(vm_klasses));
>
> The indentation is intentional: vm is a subset of boot classes, which is a
> subset of instance classes.
Okay but I presume the indent level should be the same: boot was indented by 2,
then vm only be 1.
>> src/hotspot/share/cds/archiveUtils.cpp line 390:
>>
>>> 388: return "boot"; // boot classes in java.base
>>> 389: } else {
>>> 390: return "boot2"; // boot classes outside of java.base
>>
>> Suggestion: boot -> boot-base, boot2 -> boot-nonbase ?
>
> I prefer boot/boot2 to make the output easier to read. Anyone debugging this
> output will need to read the code to understand what "boot2" or
> "boot-nonbase" is. A few extra characters here will not help.
Sorry but '2' conveys zero information whereas 'nonbase' tells you they are not
in the base module.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1749399548
PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1749399859
