On Wed, 18 Sep 2024 05:35:42 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed ZERO build
>
> test/hotspot/jtreg/runtime/cds/appcds/aotClassLinking/AOTClassLinkingVMOptions.java
> line 57:
>
>> 55: testCase("Archived full module graph must be enabled at
>> runtime");
>> 56: TestCommon.run("-cp", appJar, "-Djdk.module.validation=1",
>> "Hello")
>> 57: .assertAbnormalExit("CDS archive has aot-linked classes." +
>
> Nit: align the dots
The CDS test cases indent by 4 spaces in this situation. I searched for `'^
*[.]'` lines in the JDK source code and indentation of 8 and 4 spaces seem to
be most common.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1766089235
