On Wed, 18 Sep 2024 05:11:48 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed ZERO build
>
> src/hotspot/share/cds/archiveBuilder.cpp line 316:
>
>> 314:
>> 315: if (CDSConfig::is_dumping_aot_linked_classes()) {
>> 316: _estimated_hashtable_bytes += _klasses->length() * 16 *
>> sizeof(Klass*);
>
> Why 16?
Doing the estimate is actually difficult here (and also pointless). I've filed
https://bugs.openjdk.org/browse/JDK-8340416 to remove the estimation
altogether. For the time being, I change the estimate to 20MB which will be
more than enough.
> src/hotspot/share/cds/archiveBuilder.cpp line 877:
>
>> 875: if (ik->is_hidden()) {
>> 876: ADD_COUNT(num_hidden_klasses);
>> 877: hidden = " hidden";
>
> Why not do this at the same time you do the other hidden class updates above?
I moved the code.
> src/hotspot/share/cds/cds_globals.hpp line 99:
>
>> 97:
>> \
>> 98: /*========== New "AOT" flags
>> =========================================*/ \
>> 99: /* The following 3 flags are aliases of -Xshare:dump, */
>> \
>
> Nit: align the `*/`.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1766116185
PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1766116232
PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1766116258
