On Wed, 18 Sep 2024 01:56:36 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor comment fix
>
> src/hotspot/share/cds/aotClassLinker.cpp line 212:
>
>> 210: } else {
>> 211: const char* category = class_category_name(list.at(0));
>> 212: log_info(cds, aot, link)("written %d class(es) for category %s",
>> list.length(), category);
>
> Suggestion:
>
> log_info(cds, aot, link)("wrote %d class(es) for category %s",
> list.length(), category);
Fixed
> src/hotspot/share/cds/aotClassLinker.hpp line 100:
>
>> 98: static bool is_vm_class(InstanceKlass* ik);
>> 99:
>> 100: // When CDS is enabled, is ik guatanteed to be linked at deployment
>> time (and
>
> Suggestion:
>
> // When CDS is enabled, is ik guaranteed to be linked at deployment time
> (and
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1766121912
PR Review Comment: https://git.openjdk.org/jdk/pull/20843#discussion_r1766121483
