On Sat, 7 Sep 2024 00:30:34 GMT, Ioi Lam <ik...@openjdk.org> wrote:

>> I've taken an initial look through but there is an awful lot to try and 
>> digest here. I've flagged numerous typos and minor nits.
>> 
>> One general query: does this stuff work if the user defines their own 
>> initial application classloader?
>
>> I've taken an initial look through but there is an awful lot to try and 
>> digest here. I've flagged numerous typos and minor nits.
>> 
>> One general query: does this stuff work if the user defines their own 
>> initial application classloader?
> 
> Hi David thanks for the review. I've pushed a new version that has most of 
> your suggestions.
> 
> I also added code to avoid loading the CDS archive if it has aot-linked 
> classes, and the user has specified `-Djava.system.class.loader`

@iklam thank you for addressing the comments.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20843#issuecomment-2354146490

Reply via email to