[jira] [Assigned] (KAFKA-19084) Port KAFKA-16224 for acknowledgements in ShareConsumers.

2025-04-04 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivsundar R reassigned KAFKA-19084: Assignee: Shivsundar R > Port KAFKA-16224 for acknowledgements in ShareConsumers. > -

[jira] [Created] (KAFKA-19084) Port KAFKA-16224 for acknowledgements in ShareConsumers.

2025-04-04 Thread Shivsundar R (Jira)
Shivsundar R created KAFKA-19084: Summary: Port KAFKA-16224 for acknowledgements in ShareConsumers. Key: KAFKA-19084 URL: https://issues.apache.org/jira/browse/KAFKA-19084 Project: Kafka Issu

[PR] KAFKA-19084: Port KAFKA-16224, KAFKA-16764 for ShareConsumers [kafka]

2025-04-04 Thread via GitHub
ShivsundarR opened a new pull request, #19369: URL: https://github.com/apache/kafka/pull/19369 *What* Currently for ShareConsumers, if we receive an `UNKNOWN_TOPIC_OR_PARTITION` error code in the `ShareAcknowledgeResponse`, then we retry sending the acknowledgements until the timer expir

Re: [PR] KAFKA-19077: Propagate shutdownRequested field [kafka]

2025-04-04 Thread via GitHub
lucasbru commented on code in PR #19359: URL: https://github.com/apache/kafka/pull/19359#discussion_r2028433315 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java: ## @@ -197,6 +197,13 @@ public static class DeadlineAndEpoch { *

Re: [PR] KAFKA-19077: Propagate shutdownRequested field [kafka]

2025-04-04 Thread via GitHub
lucasbru commented on code in PR #19359: URL: https://github.com/apache/kafka/pull/19359#discussion_r2028429508 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2070,8 +2067,6 @@ private CoordinatorResult stream Str

Re: [PR] KAFKA-19077: Propagate shutdownRequested field [kafka]

2025-04-04 Thread via GitHub
lucasbru commented on code in PR #19359: URL: https://github.com/apache/kafka/pull/19359#discussion_r2028433315 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java: ## @@ -197,6 +197,13 @@ public static class DeadlineAndEpoch { *

[PR] KAFKA-19085: SharePartitionManagerTest testMultipleConcurrentShareFetches throws silent exception and works incorrectly [kafka]

2025-04-04 Thread via GitHub
adixitconfluent opened a new pull request, #19370: URL: https://github.com/apache/kafka/pull/19370 ### What The tests testMultipleConcurrentShareFetches is throwing a silent exception. ERROR Error processing delayed share fetch request (kafka.server.share.DelayedShareFetch:225)

Re: [PR] KAFKA-19077: Propagate shutdownRequested field [kafka]

2025-04-04 Thread via GitHub
lucasbru commented on code in PR #19359: URL: https://github.com/apache/kafka/pull/19359#discussion_r2028446403 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -16233,6 +16233,97 @@ public void testStreamsGroupMemberJoi

[PR] KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-04-04 Thread via GitHub
m1a2st opened a new pull request, #19371: URL: https://github.com/apache/kafka/pull/19371 The main reason is that we forgot setting the `TopicConfig.SEGMENT_BYTES_CONFIG` at least to `1024 * 1024`, thus addressed it, and add a test for it. -- This is an automated message from the Apache

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-04-04 Thread via GitHub
AndrewJSchofield commented on PR #18976: URL: https://github.com/apache/kafka/pull/18976#issuecomment-2778570067 @chirag-wadhwa5 Please could you resolve the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Created] (KAFKA-19081) Share session capacity and eviction

2025-04-04 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19081: Summary: Share session capacity and eviction Key: KAFKA-19081 URL: https://issues.apache.org/jira/browse/KAFKA-19081 Project: Kafka Issue Type: Sub-t

[PR] [MINOR] Cleanup Core Module [kafka]

2025-04-04 Thread via GitHub
sjhajharia opened a new pull request, #19372: URL: https://github.com/apache/kafka/pull/19372 Now that Kafka Brokers support Java 17, this PR makes some changes in core module. The changes in this PR are limited to only the Java files in the Core module. Scala related changes may follow nex

Re: [PR] KAFKA-19001: Use streams group-level configurations in heartbeat [kafka]

2025-04-04 Thread via GitHub
lucasbru commented on code in PR #19219: URL: https://github.com/apache/kafka/pull/19219#discussion_r2028521537 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -18070,6 +18241,101 @@ public void testShareGroupDynamicConf

Re: [PR] KAFKA-19001: Use streams group-level configurations in heartbeat [kafka]

2025-04-04 Thread via GitHub
lucasbru commented on code in PR #19219: URL: https://github.com/apache/kafka/pull/19219#discussion_r2028522022 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -18070,6 +18241,101 @@ public void testShareGroupDynamicConf

Re: [PR] KAFKA-19077: Propagate shutdownRequested field [kafka]

2025-04-04 Thread via GitHub
lucasbru commented on code in PR #19359: URL: https://github.com/apache/kafka/pull/19359#discussion_r2028446631 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/StreamsGroupTest.java: ## @@ -1106,4 +1106,32 @@ public void testIsSubscribedToTopic() {

Re: [PR] KAFKA-19001: Use streams group-level configurations in heartbeat [kafka]

2025-04-04 Thread via GitHub
lucasbru commented on code in PR #19219: URL: https://github.com/apache/kafka/pull/19219#discussion_r2028522552 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -15776,6 +15779,76 @@ public void testStreamsGroupMemberEpoc

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-04 Thread via GitHub
mimaison commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2027343207 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -413,24 +418,19 @@ void testRemoteLogMetadataManagerWithEndpointConfigOverridden() throws IOEx

Re: [PR] KAFKA-19074: Remove the cached responseData from ShareFetchResponse [kafka]

2025-04-04 Thread via GitHub
FrankYang0529 commented on code in PR #19357: URL: https://github.com/apache/kafka/pull/19357#discussion_r2028360352 ## server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTest.java: ## @@ -66,6 +79,19 @@ public void testErrorInAllPartitions() { assertTru

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

2025-04-04 Thread via GitHub
AndrewJSchofield commented on code in PR #19328: URL: https://github.com/apache/kafka/pull/19328#discussion_r2028378471 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1365,6 +1368,67 @@ public CompletableFuture descri

Re: [PR] MINOR: Added trace logs to help debug SharePartition [kafka]

2025-04-04 Thread via GitHub
AndrewJSchofield merged PR #19358: URL: https://github.com/apache/kafka/pull/19358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-14523: Move DelayedRemoteListOffsets to the storage module [kafka]

2025-04-04 Thread via GitHub
chia7712 commented on code in PR #19285: URL: https://github.com/apache/kafka/pull/19285#discussion_r2028502006 ## storage/src/main/java/org/apache/kafka/server/purgatory/DelayedRemoteListOffsets.java: ## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-19077: Propagate shutdownRequested field [kafka]

2025-04-04 Thread via GitHub
lucasbru commented on PR #19359: URL: https://github.com/apache/kafka/pull/19359#issuecomment-2778072098 @mjsax @jeffkbkim Thanks for the comments! All addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-19001: Use streams group-level configurations in heartbeat [kafka]

2025-04-04 Thread via GitHub
lucasbru commented on code in PR #19219: URL: https://github.com/apache/kafka/pull/19219#discussion_r2028511160 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/MockTaskAssignor.java: ## @@ -60,6 +65,7 @@ public String name() { @Override pu

[jira] [Created] (KAFKA-19086) Extending support for Microsecond Precision for Kafka Connect

2025-04-04 Thread Pritam Kumar (Jira)
Pritam Kumar created KAFKA-19086: Summary: Extending support for Microsecond Precision for Kafka Connect Key: KAFKA-19086 URL: https://issues.apache.org/jira/browse/KAFKA-19086 Project: Kafka

Re: [PR] MINOR VerifableProducer ducktape can set idempotency and retries [kafka]

2025-04-04 Thread via GitHub
FrankYang0529 commented on code in PR #19362: URL: https://github.com/apache/kafka/pull/19362#discussion_r2028331394 ## tests/kafkatest/services/verifiable_producer.py: ## @@ -147,9 +147,10 @@ def _worker(self, idx, node): if self.enable_idempotence: self.l

[PR] KAFKA-19025: Reuse LZ4 buffers for compression [kafka]

2025-04-04 Thread via GitHub
squah-confluent opened a new pull request, #19260: URL: https://github.com/apache/kafka/pull/19260 Introduce a buffer reuse mechanism for LZ4 compression, similar to the ones Snappy and zstd compression have. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] KAFKA-15931: Cancel RemoteLogReader gracefully [kafka]

2025-04-04 Thread via GitHub
jeqo commented on PR #19150: URL: https://github.com/apache/kafka/pull/19150#issuecomment-2768303521 Opened https://github.com/apache/kafka/pull/19331 for 4.0 backport -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] KAFKA-18576: Convert ConfigType to Enum [kafka]

2025-04-04 Thread via GitHub
chia7712 commented on code in PR #18711: URL: https://github.com/apache/kafka/pull/18711#discussion_r2008102525 ## server-common/src/main/java/org/apache/kafka/server/config/ConfigType.java: ## @@ -16,19 +16,30 @@ */ package org.apache.kafka.server.config; +import java.util

Re: [PR] MINOR: Remove DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest flaky annotation [kafka]

2025-04-04 Thread via GitHub
chia7712 merged PR #19301: URL: https://github.com/apache/kafka/pull/19301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Assigned] (KAFKA-19087) Move TransactionState to transaction-coordinator module

2025-04-04 Thread Cheng Yi Chang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Yi Chang reassigned KAFKA-19087: -- Assignee: Cheng Yi Chang (was: Chia-Ping Tsai) > Move TransactionState to transactio

Re: [PR] MINOR: Update Mockito on 3.9 for Java 23 support [kafka]

2025-04-04 Thread via GitHub
chia7712 merged PR #19367: URL: https://github.com/apache/kafka/pull/19367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-04 Thread via GitHub
OmniaGM commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2778290434 > That's great, thanks! @ijuma and @jolshan I fixed the conflicts now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Commented] (KAFKA-19087) Move TransactionState to transaction-coordinator module

2025-04-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940938#comment-17940938 ] Chia-Ping Tsai commented on KAFKA-19087: Maybe we should consider leveraging `Tr

Re: [PR] KAFKA-19001: Use streams group-level configurations in heartbeat [kafka]

2025-04-04 Thread via GitHub
lucasbru commented on code in PR #19219: URL: https://github.com/apache/kafka/pull/19219#discussion_r2028472624 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -8148,7 +8174,10 @@ private TaskAssignor streamsGroupAssignor(St

[jira] [Created] (KAFKA-19088) Consider logging the unknownStateFilters when listing transation ids

2025-04-04 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19088: -- Summary: Consider logging the unknownStateFilters when listing transation ids Key: KAFKA-19088 URL: https://issues.apache.org/jira/browse/KAFKA-19088 Project: Kaf

Re: [PR] KAFKA-18761: [2/N] List share group offsets with state and auth [kafka]

2025-04-04 Thread via GitHub
AndrewJSchofield merged PR #19328: URL: https://github.com/apache/kafka/pull/19328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Commented] (KAFKA-19088) Consider logging the unknownStateFilters when listing transation ids

2025-04-04 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940959#comment-17940959 ] Jhen-Yung Hsu commented on KAFKA-19088: --- Hi, I'm working on this, thanks. :) > Co

[jira] [Assigned] (KAFKA-19088) Consider logging the unknownStateFilters when listing transation ids

2025-04-04 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu reassigned KAFKA-19088: - Assignee: Jhen-Yung Hsu (was: Chia-Ping Tsai) > Consider logging the unknownStateFilte

[jira] [Created] (KAFKA-19031) Ensure brokers do not return null records in ShareFetchResponse

2025-04-04 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-19031: Summary: Ensure brokers do not return null records in ShareFetchResponse Key: KAFKA-19031 URL: https://issues.apache.org/jira/browse/KAFKA-19031 Project: Kafk

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-04 Thread via GitHub
OmniaGM commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2773053998 > @OmniaGM Would you like someone to help get this over the finish line? I am nearly done with fixing the conflict should publish this this week. sorry for late replay I have been a

Re: [PR] [MINOR] Cleanup Core Module [kafka]

2025-04-04 Thread via GitHub
sjhajharia commented on PR #19372: URL: https://github.com/apache/kafka/pull/19372#issuecomment-2779234357 Thanks @m1a2st for the review. I have addressed the comments and pushed a fresh commit. Pls review when possible. -- This is an automated message from the Apache Git Service. To r

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-04 Thread via GitHub
adixitconfluent commented on PR #19261: URL: https://github.com/apache/kafka/pull/19261#issuecomment-2774680482 > Thanks for the updates. In general, I'm happy with the PR, with the exception of the `filterRecordBatchesFromAcquiredRecords` method. It needs much more comprehensive commenting

[jira] [Created] (KAFKA-19085) SharePartitionManagerTest testMultipleConcurrentShareFetches throws silent exception and works incorrectly

2025-04-04 Thread Abhinav Dixit (Jira)
Abhinav Dixit created KAFKA-19085: - Summary: SharePartitionManagerTest testMultipleConcurrentShareFetches throws silent exception and works incorrectly Key: KAFKA-19085 URL: https://issues.apache.org/jira/browse/K

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-04-04 Thread via GitHub
junrao commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2025673505 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -87,7 +87,7 @@ public FetchResponseData data() { * We may also return INCONSIST

[jira] [Commented] (KAFKA-19066) JDK 24 support

2025-04-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940079#comment-17940079 ] Chia-Ping Tsai commented on KAFKA-19066: related to https://github.com/apache/ka

[jira] [Created] (KAFKA-19087) Move TransactionState to transaction-coordinator module

2025-04-04 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19087: -- Summary: Move TransactionState to transaction-coordinator module Key: KAFKA-19087 URL: https://issues.apache.org/jira/browse/KAFKA-19087 Project: Kafka I

Re: [PR] KAFKA-16718-2/n: KafkaAdminClient and GroupCoordinator implementation for DeleteShareGroupOffsets RPC [kafka]

2025-04-04 Thread via GitHub
chirag-wadhwa5 commented on PR #18976: URL: https://github.com/apache/kafka/pull/18976#issuecomment-2778711584 Hi @AndrewJSchofield, I have resolved the conflicts. The PR is ready for another round of review. Thanks ! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] MINOR cleanup log related test [kafka]

2025-04-04 Thread via GitHub
m1a2st commented on code in PR #19375: URL: https://github.com/apache/kafka/pull/19375#discussion_r2028926018 ## core/src/test/scala/unit/kafka/log/LogManagerTest.scala: ## @@ -147,7 +150,10 @@ class LogManagerTest { assertEquals(1, logManager.liveLogDirs.size) val log

Re: [PR] MINOR: Clean up unreachable code in FetcherTest [kafka]

2025-04-04 Thread via GitHub
frankvicky commented on code in PR #19376: URL: https://github.com/apache/kafka/pull/19376#discussion_r2029040633 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() {

[PR] KAFKA-19037: Integrate consumer-side code with Streams [kafka]

2025-04-04 Thread via GitHub
cadonna opened a new pull request, #19377: URL: https://github.com/apache/kafka/pull/19377 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comm

Re: [PR] MINOR: Use readable interface to parse response [kafka]

2025-04-04 Thread via GitHub
trnguyencflt commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2029055199 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java: ## @@ -51,8 +53,8 @@ final ByteBuffer serializeWithHeader(ResponseHeader header,

Re: [PR] MINOR: Use readable interface to parse response [kafka]

2025-04-04 Thread via GitHub
trnguyencflt commented on PR #19353: URL: https://github.com/apache/kafka/pull/19353#issuecomment-2779128261 [nit] Please remove this block "Delete this text " from the description of the PR. Otherwise, LGTM -- This is an automated message from the Apache Git Service. To respon

[jira] [Assigned] (KAFKA-19089) Gradle :test task failing unexpectedly

2025-04-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-19089: -- Assignee: Chia-Ping Tsai > Gradle :test task failing unexpectedly > -

[PR] MINOR cleanup log related test [kafka]

2025-04-04 Thread via GitHub
m1a2st opened a new pull request, #19375: URL: https://github.com/apache/kafka/pull/19375 Some parameter is unused and fix assertion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: Consider repartition source topic for changelog topics [kafka]

2025-04-04 Thread via GitHub
lucasbru merged PR #19373: URL: https://github.com/apache/kafka/pull/19373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] [WIP]KAFKA-19080 The constraint on segment.ms is not enforced at topic level [kafka]

2025-04-04 Thread via GitHub
m1a2st commented on PR #19371: URL: https://github.com/apache/kafka/pull/19371#issuecomment-2778790334 Hello @junrao, @chia7712 I have a question about this problem. In [[KAFKA-16368](https://github.com/apache/kafka/pull/18140/files)](https://github.com/apache/kafka/pull/18140/files),

Re: [PR] KAFKA-19074: Remove the cached responseData from ShareFetchResponse [kafka]

2025-04-04 Thread via GitHub
TaiJuWu commented on code in PR #19357: URL: https://github.com/apache/kafka/pull/19357#discussion_r2029013870 ## server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTest.java: ## @@ -43,11 +52,15 @@ public class ShareFetchTest { private static final String M

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2025-04-04 Thread via GitHub
Parkerhiphop commented on code in PR #16532: URL: https://github.com/apache/kafka/pull/16532#discussion_r2029035269 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3665,6 +3670,18 @@ public void testWhenFetchResponseReturnsALeaderSh

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2025-04-04 Thread via GitHub
Parkerhiphop commented on code in PR #16532: URL: https://github.com/apache/kafka/pull/16532#discussion_r2029035269 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3665,6 +3670,18 @@ public void testWhenFetchResponseReturnsALeaderSh

[PR] MINOR: Consider repartition source topic for changelog topics [kafka]

2025-04-04 Thread via GitHub
cadonna opened a new pull request, #19373: URL: https://github.com/apache/kafka/pull/19373 With the Streams rebalance protocol, when the partition count for changelog topics are computed the topic manager only considers external source topics and throws if there are no source topics

Re: [PR] MINOR: Clean up unreachable code in FetcherTest [kafka]

2025-04-04 Thread via GitHub
m1a2st commented on code in PR #19376: URL: https://github.com/apache/kafka/pull/19376#discussion_r2029039303 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() { resp

[PR] MINOR: Clean up unreachable code in FetcherTest [kafka]

2025-04-04 Thread via GitHub
Parkerhiphop opened a new pull request, #19376: URL: https://github.com/apache/kafka/pull/19376 This is from [#16532's comment](https://github.com/apache/kafka/pull/16532/files#r2028985028): The forEach loop in the assertion will never execute because `nonResponseData` is empty.

Re: [PR] MINOR: Clean up unreachable code in FetcherTest [kafka]

2025-04-04 Thread via GitHub
chia7712 commented on code in PR #19376: URL: https://github.com/apache/kafka/pull/19376#discussion_r2029039198 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() { re

[PR] KAFKA-19030: Remove metricNamePrefix from RequestChannel [kafka]

2025-04-04 Thread via GitHub
Parkerhiphop opened a new pull request, #19374: URL: https://github.com/apache/kafka/pull/19374 As described in the JIRA ticket, controlPlaneRequestChannelOpt was removed from KRaft mode, so there's no need to use the metrics prefix anymore. This change removes `metricNamePrefix` from

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2025-04-04 Thread via GitHub
FrankYang0529 commented on code in PR #16532: URL: https://github.com/apache/kafka/pull/16532#discussion_r2028985028 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3665,6 +3670,18 @@ public void testWhenFetchResponseReturnsALeaderS

Re: [PR] KAFKA-19074: Remove the cached responseData from ShareFetchResponse [kafka]

2025-04-04 Thread via GitHub
FrankYang0529 commented on code in PR #19357: URL: https://github.com/apache/kafka/pull/19357#discussion_r2028994700 ## server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTest.java: ## @@ -43,11 +52,15 @@ public class ShareFetchTest { private static final St

Re: [PR] MINOR: ShutdownableThread: log on error level on FatalExitError [kafka]

2025-04-04 Thread via GitHub
soarez merged PR #19351: URL: https://github.com/apache/kafka/pull/19351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] [MINOR] Cleanup Core Module [kafka]

2025-04-04 Thread via GitHub
m1a2st commented on code in PR #19372: URL: https://github.com/apache/kafka/pull/19372#discussion_r2029065027 ## core/src/main/java/kafka/server/share/SharePartitionManager.java: ## @@ -357,7 +356,7 @@ public CompletableFuture { return isrSize == 0 && elrSize ==

Re: [PR] MINOR: Clean up unreachable code in FetcherTest [kafka]

2025-04-04 Thread via GitHub
Parkerhiphop commented on code in PR #19376: URL: https://github.com/apache/kafka/pull/19376#discussion_r2029101369 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() {

Re: [PR] MINOR: Backport Gradle upgrades to 3.9 [kafka]

2025-04-04 Thread via GitHub
chia7712 merged PR #19365: URL: https://github.com/apache/kafka/pull/19365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Clean up unreachable code in FetcherTest [kafka]

2025-04-04 Thread via GitHub
Parkerhiphop commented on code in PR #19376: URL: https://github.com/apache/kafka/pull/19376#discussion_r2029102952 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() {

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2025-04-04 Thread via GitHub
chia7712 commented on code in PR #16532: URL: https://github.com/apache/kafka/pull/16532#discussion_r2028993496 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3665,6 +3670,18 @@ public void testWhenFetchResponseReturnsALeaderShipCh

[jira] [Created] (KAFKA-19089) Gradle :test task failing unexpectedly

2025-04-04 Thread David Arthur (Jira)
David Arthur created KAFKA-19089: Summary: Gradle :test task failing unexpectedly Key: KAFKA-19089 URL: https://issues.apache.org/jira/browse/KAFKA-19089 Project: Kafka Issue Type: Bug

Re: [PR] KAFKA-7952: use in memory stores for KTable test [kafka]

2025-04-04 Thread via GitHub
mjsax merged PR #19218: URL: https://github.com/apache/kafka/pull/19218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-04-04 Thread via GitHub
frankvicky commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r2029109982 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java: ## @@ -182,7 +181,7 @@ public NetworkClientDelegate.PollRe

Re: [PR] KAFKA-19070:: Adding task number to user provided client id to ensure each consumer has a unique client ID to avoid metric registration conflicts. [kafka]

2025-04-04 Thread via GitHub
kumarpritam863 commented on PR #19341: URL: https://github.com/apache/kafka/pull/19341#issuecomment-2779267375 Hi @mimaison can you please review this. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] MINOR: rename streams group configs for consistency with other configuration settings. [kafka]

2025-04-04 Thread via GitHub
lucasbru merged PR #19360: URL: https://github.com/apache/kafka/pull/19360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Clean up unreachable code in FetcherTest [kafka]

2025-04-04 Thread via GitHub
frankvicky commented on code in PR #19376: URL: https://github.com/apache/kafka/pull/19376#discussion_r2029047826 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() {

Re: [PR] KAFKA-19030: Remove metricNamePrefix from RequestChannel [kafka]

2025-04-04 Thread via GitHub
Parkerhiphop commented on code in PR #19374: URL: https://github.com/apache/kafka/pull/19374#discussion_r2028918289 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -349,8 +348,8 @@ class RequestChannel(val queueSize: Int, private val requestQueue = new Arra

Re: [PR] KAFKA-19077: Propagate shutdownRequested field [kafka]

2025-04-04 Thread via GitHub
lucasbru commented on code in PR #19359: URL: https://github.com/apache/kafka/pull/19359#discussion_r2028433315 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java: ## @@ -197,6 +197,13 @@ public static class DeadlineAndEpoch { *

Re: [PR] MINOR: Use readable interface to parse response [kafka]

2025-04-04 Thread via GitHub
soondenana commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2029166476 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java: ## @@ -51,8 +53,8 @@ final ByteBuffer serializeWithHeader(ResponseHeader header, sh

[PR] KAFKA-19057: Stabilize KIP-932 RPCs for AK 4.1 [kafka]

2025-04-04 Thread via GitHub
AndrewJSchofield opened a new pull request, #19378: URL: https://github.com/apache/kafka/pull/19378 This PR removes the unstable API flag for the KIP-932 RPCs. The 4 RPCs which were exposed for the early access release in AK 4.0 are stabilised at v1. This is because the RPCs have evol

[jira] [Updated] (KAFKA-19073) Add Transactional ID pattern filter to ListTransactions API

2025-04-04 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-19073: --- Summary: Add Transactional ID pattern filter to ListTransactions API (was: Add Transactional ID pre

[jira] [Resolved] (KAFKA-18761) kafka-share-groups.sh --describe only shows offset information when members exist

2025-04-04 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-18761. -- Resolution: Fixed > kafka-share-groups.sh --describe only shows offset information whe

[jira] [Assigned] (KAFKA-18902) Implement ShareConsumer option to throw on poll if there are unacked records

2025-04-04 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-18902: Assignee: Shivsundar R (was: Andrew Schofield) > Implement ShareConsumer option

[jira] [Updated] (KAFKA-19089) Gradle :test task failing unexpectedly

2025-04-04 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-19089: - Component/s: build > Gradle :test task failing unexpectedly > --

Re: [PR] KAFKA-18892: KIP-877 Add support for ClientQuotaCallback [kafka]

2025-04-04 Thread via GitHub
m1a2st commented on PR #19068: URL: https://github.com/apache/kafka/pull/19068#issuecomment-2777484507 Thanks for @mimaison review, addressed all comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-04 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2022590789 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -407,14 +413,17 @@ private void configureRLMM() { rlmmProps.put(LOG_DIR_CONFIG, logDir);

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-04-04 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r2025873637 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerHeartbeatRequestManager.java: ## @@ -211,6 +214,28 @@ public ConsumerMembershipManager

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-04-04 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2022946269 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2484,6 +2504,205 @@ private long startOffsetDuringInitialization(long partitionDataStartOf

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-04-04 Thread via GitHub
frankvicky commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2025822378 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -87,7 +87,7 @@ public FetchResponseData data() { * We may also return INCON

[jira] [Commented] (KAFKA-19033) FindCoordinator API always return COORDINATOR_NOT_AVAILABLE for CoordinatorType.SHARE

2025-04-04 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937947#comment-17937947 ] David Jacot commented on KAFKA-19033: - I alraedy have a patch for it: https://github

[jira] [Assigned] (KAFKA-18900) Create a consumer config to select between implicit and explicit acknowledgement

2025-04-04 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-18900: Assignee: Shivsundar R (was: Andrew Schofield) > Create a consumer config to sel

[PR] Cleanup core 2 [kafka]

2025-04-04 Thread via GitHub
sjhajharia opened a new pull request, #19379: URL: https://github.com/apache/kafka/pull/19379 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some c

Re: [PR] Cleanup core 2 [kafka]

2025-04-04 Thread via GitHub
sjhajharia closed pull request #19379: Cleanup core 2 URL: https://github.com/apache/kafka/pull/19379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: ji

Re: [PR] MINOR: Clean up unreachable code in FetcherTest [kafka]

2025-04-04 Thread via GitHub
Parkerhiphop commented on code in PR #19376: URL: https://github.com/apache/kafka/pull/19376#discussion_r2029097843 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3663,8 +3663,7 @@ public void testFetcherDontCacheAnyData() {

Re: [PR] KAFKA-16684: Remove cache in responseData [kafka]

2025-04-04 Thread via GitHub
TaiJuWu commented on code in PR #16532: URL: https://github.com/apache/kafka/pull/16532#discussion_r2029018014 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java: ## @@ -3665,6 +3670,18 @@ public void testWhenFetchResponseReturnsALeaderShipCha

[jira] [Commented] (KAFKA-19079) KIP-890 Cleanups

2025-04-04 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17941041#comment-17941041 ] Justine Olshan commented on KAFKA-19079: [~iamoshione]  KIP-890 is a kafka impr

[jira] [Assigned] (KAFKA-15758) Always schedule wrapped callbacks

2025-04-04 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-15758: -- Assignee: David Jacot > Always schedule wrapped callbacks >

[jira] [Updated] (KAFKA-19073) Add Transactional ID prefix filter to ListTransactions API

2025-04-04 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-19073: --- Description: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1152%3A+Add+transactional+ID+patt

  1   2   3   >