m1a2st commented on PR #19371: URL: https://github.com/apache/kafka/pull/19371#issuecomment-2778790334
Hello @junrao, @chia7712 I have a question about this problem. In [[KAFKA-16368](https://github.com/apache/kafka/pull/18140/files)](https://github.com/apache/kafka/pull/18140/files), only the `ServerLogConfigs` value for `log.segment.bytes` was modified to 1 MB. However, the `TopicConfig` default for `segment.bytes` remains 14 bytes. Many tests rely on this small `segment.bytes` value to generate a large number of segments. I think there are two possible approaches to resolve this: 1. Add `atLeast(1024 * 1024)` validation in `LogConfig`, which would require fixing around 400 tests. 2. Add a validator in `LogManager#updateTopicConfig` to validate the change request at runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
