junrao commented on code in PR #19167:
URL: https://github.com/apache/kafka/pull/19167#discussion_r2025673505
##########
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##########
@@ -87,7 +87,7 @@ public FetchResponseData data() {
* We may also return INCONSISTENT_TOPIC_ID error as a partition-level
error when a partition in the session has a topic ID
* inconsistent with the log.
*/
- public FetchResponse(FetchResponseData fetchResponseData) {
+ FetchResponse(FetchResponseData fetchResponseData) {
Review Comment:
I thought that we wanted to make this private so that all callers on the
server side will go through the `of` constructor that has the null check on
`records`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
