lucasbru commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2028433315
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##########
@@ -197,6 +197,13 @@ public static class DeadlineAndEpoch {
*/
private DeadlineAndEpoch metadataRefreshDeadline = DeadlineAndEpoch.EMPTY;
+ /**
+ * A flag to indicate whether a shutdown has been requested for this group.
+ * This has no direct effect inside the group coordinator, but is
propagated to all members of the group.
+ * This is not persisted in the log.
Review Comment:
Yes, I also wasn't sure about these things, so we discussed it in this
thread: https://confluent.slack.com/archives/C06UA1XN326/p1743686382861189
The aim of the PR is to keep it simple, so:
- The flag is best-effort, as in the old protocol
- The flag remains set until either there is a coordinator failover, or all
members have shutdown. The members are not expected to be restarted when they
receive this flag. If a new member joins the group before the last old member
has shutdown, it will also be asked to shut down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
