lucasbru commented on code in PR #19219:
URL: https://github.com/apache/kafka/pull/19219#discussion_r2028511160


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/MockTaskAssignor.java:
##########
@@ -60,6 +65,7 @@ public String name() {
     @Override
     public GroupAssignment assign(final GroupSpec groupSpec, final 
TopologyDescriber topologyDescriber)
         throws TaskAssignorException {
+        assignmentConfigs = groupSpec.assignmentConfigs();

Review Comment:
   We are using `lastPassedAssignmentConfigs` to test which configs are passed 
to the assignor. The `assignmentConfigs` were already there in the `GroupSpec`, 
not changes were required. The Mockassignor was just ignoring the map.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to