frankvicky commented on code in PR #19376:
URL: https://github.com/apache/kafka/pull/19376#discussion_r2029047826
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##########
@@ -3664,7 +3664,6 @@ public void testFetcherDontCacheAnyData() {
responseData.forEach((topicPartition, partitionData) ->
assertEquals(records, partitionData.records()));
LinkedHashMap<TopicPartition, FetchResponseData.PartitionData>
nonResponseData = fetchResponse.responseData(emptyMap(), version);
assertEquals(emptyMap().size(), nonResponseData.size());
Review Comment:
I suggest that we use assertTrue for this case.
IDEA will have a mark the post iteration is unnecessary after assert empty
but it won't do the same thing for assert 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
