m1a2st commented on code in PR #19375:
URL: https://github.com/apache/kafka/pull/19375#discussion_r2028926018
##########
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##########
@@ -147,7 +150,10 @@ class LogManagerTest {
assertEquals(1, logManager.liveLogDirs.size)
val logFile = new File(logDir, name + "-0")
assertTrue(logFile.exists)
-
assertFalse(logManager.directoryId(logFile.getParent).equals(DirectoryId.random()))
Review Comment:
The original assertion is comparing `Option[Uuid]` with `Uuid`, so it always
be false. This makes the assertion look a bit off or misleading.
##########
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##########
@@ -136,7 +136,10 @@ class LogManagerTest {
assertEquals(1, logManager.liveLogDirs.size)
val logFile = new File(logDir, name + "-0")
assertTrue(logFile.exists)
-
assertFalse(logManager.directoryId(logFile.getParent).equals(DirectoryId.UNASSIGNED))
Review Comment:
The original assertion is comparing `Option[Uuid]` with `Uuid`, so it always
be false. This makes the assertion look a bit off or misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
