adixitconfluent commented on PR #19261: URL: https://github.com/apache/kafka/pull/19261#issuecomment-2774680482
> Thanks for the updates. In general, I'm happy with the PR, with the exception of the `filterRecordBatchesFromAcquiredRecords` method. It needs much more comprehensive commenting and attention to naming. For example, it's not clear whether the input parameters are sorted and so on. This makes it difficult to work out the algorithm that it is using. Hi @AndrewJSchofield, thanks for the feedback. I have made naming changes as per your review comments and added the javadoc over the method and more comments in this method explaning my approach. Please let me know if this is explanatory enough or I need more changes. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
