ShivsundarR opened a new pull request, #19369: URL: https://github.com/apache/kafka/pull/19369
*What* Currently for ShareConsumers, if we receive an `UNKNOWN_TOPIC_OR_PARTITION` error code in the `ShareAcknowledgeResponse`, then we retry sending the acknowledgements until the timer expires. We ideally do not want this when a topic/partition is deleted, hence like the `CommitRequestManager`(https://github.com/apache/kafka/pull/15581), we will treat this error as fatal and not retry the acknowledgements. PR also suppresses `InvalidTopicException` during `unsubscribe()` which was also added in the `AsyncKafkaConsumer`(https://github.com/apache/kafka/pull/16043). It was later removed in the regular consumer here(https://github.com/apache/kafka/commit/d76238a18fb6a86b4b08bc04918ea1a0ee626517), as they notified the background operations of metadata errors instead of propagating them via `ErrorEvent`. `ShareConsumerImpl` however does not require that change and it still propagates the metadata error back to the application. So we would need to suppress this exception during unsubscribe(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
