trnguyencflt commented on code in PR #19353:
URL: https://github.com/apache/kafka/pull/19353#discussion_r2029055199
##########
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java:
##########
@@ -51,8 +53,8 @@ final ByteBuffer serializeWithHeader(ResponseHeader header,
short version) {
}
// Visible for testing
- final ByteBuffer serialize(short version) {
- return MessageUtil.toByteBufferAccessor(data(), version).buffer();
+ final ByteBufferAccessor serialize(short version) {
Review Comment:
should we return the interface (Readable/ReadableBuf) instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
