FrankYang0529 commented on code in PR #19357: URL: https://github.com/apache/kafka/pull/19357#discussion_r2028994700
########## server/src/test/java/org/apache/kafka/server/share/fetch/ShareFetchTest.java: ########## @@ -43,11 +52,15 @@ public class ShareFetchTest { private static final String MEMBER_ID = "memberId"; private static final int BATCH_SIZE = 500; + private final TopicIdPartition tidp0 = new TopicIdPartition(Uuid.randomUuid(), 0, "topic"); + private MemoryRecords records; Review Comment: These two variables are only used in `testDontCacheAnyData`. Could we move them into the case, so we don't need to build records for each test case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org