[GitHub] [samza] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r262266804 ## File path: samza-core/src/main/java/org/apache/samza/execution/JobPlanner.java ## @@ -82,10 +84,13 @@ Ex

[GitHub] [samza] Sanil15 commented on issue #920: SAMZA-2106: Samza app and job config refactor

Sanil15 commented on issue #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#issuecomment-469444362 @xinyuiscool not all the code that uses JOB.NAME, reads it of JobConfig#getName method and the same applies to JOB.ID With this approach

[GitHub] [samza] Sanil15 edited a comment on issue #920: SAMZA-2106: Samza app and job config refactor

Sanil15 edited a comment on issue #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#issuecomment-469444362 @xinyuiscool not all the code that uses JOB.NAME, reads it of JobConfig#getName method and the same applies to JOB.ID With this

[GitHub] [samza] Sanil15 edited a comment on issue #920: SAMZA-2106: Samza app and job config refactor

Sanil15 edited a comment on issue #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#issuecomment-469444362 @xinyuiscool not all the code that uses JOB.NAME, reads it of JobConfig#getName method and the same applies to JOB.ID With this

[GitHub] [samza] asfgit closed pull request #936: SAMZA-2119: Upgrading Yarn-client to 2.7.1

asfgit closed pull request #936: SAMZA-2119: Upgrading Yarn-client to 2.7.1 URL: https://github.com/apache/samza/pull/936 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [samza] srinipunuru merged pull request #937: Propogating the system messages to the stream.

srinipunuru merged pull request #937: Propogating the system messages to the stream. URL: https://github.com/apache/samza/pull/937 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [samza] shanthoosh commented on a change in pull request #935: SAMZA-2118: Improve the shutdown sequence of AsyncRunLoop.

shanthoosh commented on a change in pull request #935: SAMZA-2118: Improve the shutdown sequence of AsyncRunLoop. URL: https://github.com/apache/samza/pull/935#discussion_r262317010 ## File path: samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java ## @@ -193,6

[GitHub] [samza] lakshmi-manasa-g opened a new pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

lakshmi-manasa-g opened a new pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938 Tests yet to be written. Adds run.id only for BATCH mode and no changes for STREAM mode. Known issues: - No supp

[GitHub] [samza] Cpptz commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally

Cpptz commented on a change in pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally URL: https://github.com/apache/samza/pull/934#discussion_r262392608 ## File path: samza-core/src/main/java/org/apache/samza/context

[GitHub] [samza] shanthoosh merged pull request #935: SAMZA-2118: Improve the shutdown sequence of AsyncRunLoop.

shanthoosh merged pull request #935: SAMZA-2118: Improve the shutdown sequence of AsyncRunLoop. URL: https://github.com/apache/samza/pull/935 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [samza] xinyuiscool commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

xinyuiscool commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r262743422 ## File path: samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java ## @@ -113,7 +

[GitHub] [samza] xinyuiscool commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

xinyuiscool commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r262744411 ## File path: samza-core/src/main/java/org/apache/samza/runtime/RemoteApplicationRunner.java ## @@ -98

[GitHub] [samza] xinyuiscool commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

xinyuiscool commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r262744308 ## File path: samza-core/src/main/java/org/apache/samza/runtime/RemoteApplicationRunner.java ## @@ -84

[GitHub] [samza] xinyuiscool commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

xinyuiscool commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r26270 ## File path: samza-core/src/main/java/org/apache/samza/runtime/RemoteApplicationRunner.java ## @@ -11

[GitHub] [samza] xinyuiscool commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

xinyuiscool commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r262744515 ## File path: samza-core/src/main/java/org/apache/samza/util/JobConfigUtil.java ## @@ -0,0 +1,72 @@ +/*

[GitHub] [samza] xinyuiscool opened a new pull request #939: SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages

xinyuiscool opened a new pull request #939: SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages URL: https://github.com/apache/samza/pull/939 Currently the TaskInstance.checkCaughtUp() logic has a bug that if there is no incoming messages for a partition, it

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262756274 ## File path: samza-core/src/main/java/org/apache/samza/task/StreamOperatorTask.java ## @@ -127,6 +153,14 @

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262797705 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/AsyncStreamOperatorImpl.java ## @@ -

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262749310 ## File path: samza-api/src/main/java/org/apache/samza/operators/functions/AsyncFlatMapFunction.java ## @@

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262765022 ## File path: samza-core/src/main/java/org/apache/samza/operators/spec/AsyncOperatorSpec.java ## @@ -0,0 +1

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262764775 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/AsyncStreamOperatorImpl.java ## @@ -

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262766045 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/AsyncStreamOperatorImpl.java ## @@ -

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262765309 ## File path: samza-api/src/main/java/org/apache/samza/operators/MessageStream.java ## @@ -67,6 +68,16 @@

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262757036 ## File path: samza-core/src/test/java/org/apache/samza/operators/TestJoinOperator.java ## @@ -79,9 +81,9 @

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262762273 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/OperatorImpl.java ## @@ -184,19 +185

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262749241 ## File path: samza-api/src/main/java/org/apache/samza/operators/functions/AsyncFlatMapFunction.java ## @@

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262750469 ## File path: samza-api/src/main/java/org/apache/samza/operators/functions/AsyncFlatMapFunction.java ## @@

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262755910 ## File path: samza-core/src/main/java/org/apache/samza/task/StreamOperatorTask.java ## @@ -90,34 +94,56 @@

[GitHub] [samza] vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262766507 ## File path: samza-core/src/main/java/org/apache/samza/operators/impl/OperatorImpl.java ## @@ -159,21 +162

[GitHub] [samza] asfgit closed pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally

asfgit closed pull request #934: SAMZA-1935 : Refactor TaskContextImpl to not include access to objects that are only used internally URL: https://github.com/apache/samza/pull/934 This is an automated message from the Apache

[GitHub] [samza] sborya commented on a change in pull request #939: SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages

sborya commented on a change in pull request #939: SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages URL: https://github.com/apache/samza/pull/939#discussion_r263078743 ## File path: samza-core/src/main/scala/org/apache/samza/container/TaskInstance.

[GitHub] [samza] sborya commented on a change in pull request #939: SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages

sborya commented on a change in pull request #939: SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages URL: https://github.com/apache/samza/pull/939#discussion_r263078808 ## File path: samza-core/src/main/scala/org/apache/samza/container/TaskInstance.

[GitHub] [samza] xinyuiscool commented on a change in pull request #939: SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages

xinyuiscool commented on a change in pull request #939: SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages URL: https://github.com/apache/samza/pull/939#discussion_r263086086 ## File path: samza-core/src/main/scala/org/apache/samza/container/TaskInst

[GitHub] [samza] xinyuiscool commented on a change in pull request #939: SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages

xinyuiscool commented on a change in pull request #939: SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages URL: https://github.com/apache/samza/pull/939#discussion_r263086035 ## File path: samza-core/src/main/scala/org/apache/samza/container/TaskInst

[GitHub] [samza] cameronlee314 opened a new pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

cameronlee314 opened a new pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940 This is the first step for implementing https://issues.apache.org/jira/browse/SAMZA-2120.

[GitHub] [samza] sborya merged pull request #939: SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages

sborya merged pull request #939: SAMZA-2122: Fix the task caught-up logic which doesn't handle no incoming messages URL: https://github.com/apache/samza/pull/939 This is an automated message from the Apache Git Service. To r

[GitHub] [samza] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r263162204 ## File path: samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java ## @@ -113,7 +115,

[GitHub] [samza] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r263162260 ## File path: samza-core/src/main/java/org/apache/samza/runtime/RemoteApplicationRunner.java ## @@ -84,7 +

[GitHub] [samza] Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor

Sanil15 commented on a change in pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920#discussion_r263162324 ## File path: samza-core/src/main/java/org/apache/samza/util/JobConfigUtil.java ## @@ -0,0 +1,72 @@ +/* + *

[GitHub] [samza] prateekm commented on issue #897: SEP-19 : Refactoring to remove localityManager from JobModel

prateekm commented on issue #897: SEP-19 : Refactoring to remove localityManager from JobModel URL: https://github.com/apache/samza/pull/897#issuecomment-470334092 @rmatharu We also want to move the JobModel to samza-api (where ContainerModel and TaskModel already are). --

[GitHub] [samza] cameronlee314 opened a new pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

cameronlee314 opened a new pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941 This includes the code from https://github.com/apache/samza/pull/940. For this PR, it would be practical to just look at co

[GitHub] [samza] xinyuiscool merged pull request #920: SAMZA-2106: Samza app and job config refactor

xinyuiscool merged pull request #920: SAMZA-2106: Samza app and job config refactor URL: https://github.com/apache/samza/pull/920 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [samza] rmatharu opened a new pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

rmatharu opened a new pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942 This is an automated message from the

[GitHub] [samza] mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r262815895 ## File path: samza-core/src/main/java/org/apache/samza/coordinator/CoordinationUtils.java ###

[GitHub] [samza] mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r262817152 ## File path: samza-core/src/main/java/org/apache/samza/coordinator/DistributedReadWriteLock.ja

[GitHub] [samza] mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r262818100 ## File path: samza-core/src/main/java/org/apache/samza/coordinator/DistributedReadWriteLock.ja

[GitHub] [samza] mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r262813679 ## File path: samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java ##

[GitHub] [samza] mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r262817813 ## File path: samza-core/src/main/java/org/apache/samza/coordinator/DistributedReadWriteLock.ja

[GitHub] [samza] mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r262814871 ## File path: samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java ##

[GitHub] [samza] mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r262816170 ## File path: samza-core/src/main/java/org/apache/samza/coordinator/CoordinationUtils.java ###

[GitHub] [samza] mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r262815650 ## File path: samza-core/src/main/java/org/apache/samza/coordinator/CoordinationUtils.java ###

[GitHub] [samza] mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r262814180 ## File path: samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java ##

[GitHub] [samza] prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263505840 ## File path: samza-core/src/main/scala/org/apache/samza/sys

[GitHub] [samza] prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263506752 ## File path: samza-core/src/main/scala/org/apache/samza/sto

[GitHub] [samza] cameronlee314 commented on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

cameronlee314 commented on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#issuecomment-470661609 @rmatharu @mynameborat could you please take a look?

[GitHub] [samza] cameronlee314 commented on issue #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

cameronlee314 commented on issue #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#issuecomment-470661443 @rmatharu @mynameborat could you please take a look? --

[GitHub] [samza] rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263535250 ## File path: samza-core/src/main/scala/org/apache/samza/sto

[GitHub] [samza] rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263535250 ## File path: samza-core/src/main/scala/org/apache/samza/sto

[GitHub] [samza] vjagadish1989 commented on issue #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on issue #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#issuecomment-470672963 1. Can you add an e2e integration test for a `StreamApp` + async-api 2. Additionally, update our website-docs and add public code examples for

[GitHub] [samza] rmatharu commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

rmatharu commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#discussion_r263553107 ## File path: samza-core/src/main/java/org/apache/samza/storage/TaskSideInputStorageMana

[GitHub] [samza] rmatharu commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

rmatharu commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#discussion_r263554894 ## File path: samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java #

[GitHub] [samza] cameronlee314 commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

cameronlee314 commented on a change in pull request #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#discussion_r263575676 ## File path: samza-core/src/main/java/org/apache/samza/storage/TaskSideInputStorag

[GitHub] [samza] prateekm commented on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

prateekm commented on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#issuecomment-470707705 @cameronlee314 I'd prefer to not add new fields/semantics to IME if possible. I'm assuming you want to return the

[GitHub] [samza] mynameborat commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

mynameborat commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#discussion_r263599960 ## File path: samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java

[GitHub] [samza] cameronlee314 commented on issue #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

cameronlee314 commented on issue #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#issuecomment-470744806 > Looks good. > General question around checkpoint offset vs offset: > Are there other systems that will benef

[GitHub] [samza] cameronlee314 commented on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

cameronlee314 commented on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#issuecomment-470745081 > @cameronlee314 I'd prefer to not add new fields/semantics to IME if possible. I'm assuming you want to retu

[GitHub] [samza] cameronlee314 edited a comment on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka

cameronlee314 edited a comment on issue #941: SAMZA-2120: Enable custom handling of ConsumerRecords consumed by Kafka URL: https://github.com/apache/samza/pull/941#issuecomment-470745081 > @cameronlee314 I'd prefer to not add new fields/semantics to IME if possible. I'm assuming you want

[GitHub] [samza] dxichen opened a new pull request #943: Update Samza version for 1.1.0 release branch

dxichen opened a new pull request #943: Update Samza version for 1.1.0 release branch URL: https://github.com/apache/samza/pull/943 Change versions as per RELEASE.md This is an automated message from the Apache Git Service. T

[GitHub] [samza] dxichen opened a new pull request #944: Release version updates

dxichen opened a new pull request #944: Release version updates URL: https://github.com/apache/samza/pull/944 Updated hard coded version for the upcoming release This is an automated message from the Apache Git Service. To res

[GitHub] [samza] shanthoosh commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

shanthoosh commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#discussion_r263628931 ## File path: samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java

[GitHub] [samza] shanthoosh commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

shanthoosh commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#discussion_r263628931 ## File path: samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java

[GitHub] [samza] xinyuiscool merged pull request #943: Update Samza version for 1.1.0 release branch

xinyuiscool merged pull request #943: Update Samza version for 1.1.0 release branch URL: https://github.com/apache/samza/pull/943 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [samza] shanthoosh commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

shanthoosh commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#discussion_r263628931 ## File path: samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java

[GitHub] [samza] mynameborat commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

mynameborat commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263637333 ## File path: samza-core/src/main/scala/org/apache/samza/

[GitHub] [samza] cameronlee314 commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

cameronlee314 commented on a change in pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#discussion_r263639549 ## File path: samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.jav

[GitHub] [samza] vjagadish1989 commented on issue #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 commented on issue #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#issuecomment-470775503 @xinyuiscool: in case he has additional feedback on the async-api This is an au

[GitHub] [samza] vjagadish1989 edited a comment on issue #905: SAMZA-2055: [WIP] Async high level api

vjagadish1989 edited a comment on issue #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#issuecomment-470775503 also adding @xinyuiscool in case he has additional feedback on the async-api ---

[GitHub] [samza] shanthoosh commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

shanthoosh commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263647669 ## File path: samza-core/src/main/scala/org/apache/samza/s

[GitHub] [samza] rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263657205 ## File path: samza-core/src/main/scala/org/apache/samza/sto

[GitHub] [samza] rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263657205 ## File path: samza-core/src/main/scala/org/apache/samza/sto

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r26366 ## File path: samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.jav

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r263661126 ## File path: samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.jav

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r263661134 ## File path: samza-core/src/main/java/org/apache/samza/coordinator/CoordinationUtils.java

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r263661119 ## File path: samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.jav

[GitHub] [samza] lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing.

lakshmi-manasa-g commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r263661144 ## File path: samza-core/src/main/java/org/apache/samza/coordinator/CoordinationUtils.java

[GitHub] [samza] prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263865477 ## File path: samza-core/src/main/scala/org/apache/samza/con

[GitHub] [samza] prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263866650 ## File path: samza-core/src/main/scala/org/apache/samza/sto

[GitHub] [samza] prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263866440 ## File path: samza-core/src/main/scala/org/apache/samza/sys

[GitHub] [samza] prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263865573 ## File path: samza-core/src/main/scala/org/apache/samza/con

[GitHub] [samza] prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263877257 ## File path: samza-core/src/main/scala/org/apache/samza/sys

[GitHub] [samza] rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263878839 ## File path: samza-core/src/main/scala/org/apache/samza/sys

[GitHub] [samza] rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

rmatharu commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263878762 ## File path: samza-core/src/main/scala/org/apache/samza/sto

[GitHub] [samza] rmatharu commented on issue #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

rmatharu commented on issue #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942#issuecomment-471027740 Addressed all comments. ---

[GitHub] [samza] asfgit closed pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

asfgit closed pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric. URL: https://github.com/apache/samza/pull/942 This is an automated message from the Apache

[GitHub] [samza] cameronlee314 opened a new pull request #945: [javadoc] Clarify semantics of the offset in IncomingMessageEnvelope as the offset provided by the system consumer for the message

cameronlee314 opened a new pull request #945: [javadoc] Clarify semantics of the offset in IncomingMessageEnvelope as the offset provided by the system consumer for the message URL: https://github.com/apache/samza/pull/945

[GitHub] [samza] rmatharu opened a new pull request #946: SEP-19: Removing standbytasks.enabled config

rmatharu opened a new pull request #946: SEP-19: Removing standbytasks.enabled config URL: https://github.com/apache/samza/pull/946 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [samza] asfgit closed pull request #946: SEP-19: Removing standbytasks.enabled config

asfgit closed pull request #946: SEP-19: Removing standbytasks.enabled config URL: https://github.com/apache/samza/pull/946 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [samza] shanthoosh merged pull request #945: [javadoc] Clarify semantics of the offset in IncomingMessageEnvelope as the offset provided by the system consumer for the message

shanthoosh merged pull request #945: [javadoc] Clarify semantics of the offset in IncomingMessageEnvelope as the offset provided by the system consumer for the message URL: https://github.com/apache/samza/pull/945 This is a

[GitHub] [samza] cameronlee314 commented on issue #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

cameronlee314 commented on issue #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940#issuecomment-471117914 This is no longer necessary. See SAMZA-2121 for more details. -

[GitHub] [samza] cameronlee314 closed pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope

cameronlee314 closed pull request #940: SAMZA-2121: Add checkpoint offset field to IncomingMessageEnvelope URL: https://github.com/apache/samza/pull/940 This is an automated message from the Apache Git Service. To respond to

<    1   2   3   4   5   6   7   8   9   10   >