vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] 
Async high level api
URL: https://github.com/apache/samza/pull/905#discussion_r262757036
 
 

 ##########
 File path: 
samza-core/src/test/java/org/apache/samza/operators/TestJoinOperator.java
 ##########
 @@ -79,9 +81,9 @@ public void join() throws Exception {
     MessageCollector messageCollector = envelope -> output.add((Integer) 
envelope.getMessage());
 
     // push messages to first stream
-    numbers.forEach(n -> sot.process(new FirstStreamIME(n, n), 
messageCollector, taskCoordinator));
+    numbers.forEach(n -> sot.processAsync(new FirstStreamIME(n, n), 
messageCollector, taskCoordinator, taskCallback));
 
 Review comment:
   when and where is the taskCallback completed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to