vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP] Async high level api URL: https://github.com/apache/samza/pull/905#discussion_r262749241
########## File path: samza-api/src/main/java/org/apache/samza/operators/functions/AsyncFlatMapFunction.java ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.samza.operators.functions; + +import java.io.Serializable; +import java.util.Collection; +import java.util.concurrent.CompletionStage; +import org.apache.samza.annotation.InterfaceStability; + + +/** + * Transforms an input message into a collection of 0 or more messages, possibly of a different type. + * + * @param <M> type of the input message + * @param <OM> type of the transformed messages + */ +@InterfaceStability.Unstable +public interface AsyncFlatMapFunction<M, OM> extends InitableFunction, ClosableFunction, Serializable { + + /** + * Transforms the provided message into a collection of 0 or more messages. + * + * @param message the input message to be transformed + * @return a collection of 0 or more transformed messages + */ + CompletionStage<Collection<OM>> apply(M message); Review comment: Personally, I'd prefer to use a CompletableFuture[T] instead of CompletionStage[T]. A future conveys that it's an async computation more explicitly. Caveat: it may just be an issue with my familiarity with the new JDK interfaces. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
