xinyuiscool commented on a change in pull request #920: SAMZA-2106: Samza app
and job config refactor
URL: https://github.com/apache/samza/pull/920#discussion_r262743422
##########
File path:
samza-core/src/main/java/org/apache/samza/execution/ExecutionPlanner.java
##########
@@ -113,7 +115,7 @@ private void validateConfig() {
*/
/* package private */
JobGraph createJobGraph(ApplicationDescriptorImpl<? extends
ApplicationDescriptor> appDesc) {
- JobGraph jobGraph = new JobGraph(config, appDesc);
+ JobGraph jobGraph = new JobGraph(new MapConfig(config), appDesc);
Review comment:
why we need to wrap MapConfig on the config?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
