xinyuiscool commented on a change in pull request #920: SAMZA-2106: Samza app
and job config refactor
URL: https://github.com/apache/samza/pull/920#discussion_r262744308
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/RemoteApplicationRunner.java
##########
@@ -84,7 +85,7 @@ public void kill() {
// since currently we only support single actual remote job, we can get
its status without
// building the execution plan.
try {
- JobConfig jc = new JobConfig(appDesc.getConfig());
+ JobConfig jc = new
JobConfig(JobConfigUtil.generateJobIdAndName(appDesc.getConfig()));
Review comment:
This JobConfigUtil.generateJobIdAndName should be in the planner. You can
add a function directly there like
planer.createSingleJobConfig(). This will be better handled in a single
place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
