prateekm commented on a change in pull request #942: Bugfix: Recent CSM
refactor was causing some metrics to not be emitted. Fixed <task>-restore-time
metric.
URL: https://github.com/apache/samza/pull/942#discussion_r263506752
##########
File path:
samza-core/src/main/scala/org/apache/samza/storage/ContainerStorageManager.java
##########
@@ -573,6 +576,25 @@ private StorageEngine createStore(String storeName,
TaskName taskName, TaskModel
return
this.sideInputStorageManagers.values().stream().collect(Collectors.toSet());
}
+ /**
+ * Registers any CSM created metrics such as side-inputs related metrics,
and standby-task related metrics.
+ * @param metricsReporters metrics reporters to use
+ */
+ public void registerMetrics(Map<String, MetricsReporter> metricsReporters) {
Review comment:
I don't think this is the standard pattern. The right way would be to pass
in the shared MetricsRegistry (created in SamzaContainer) to the CSM, and
register metrics on that in CSM#register(). That MetricsRegistry is already
registered with the MetricsReporters in SamzaContainer. Does this make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
