vjagadish1989 commented on a change in pull request #905: SAMZA-2055: [WIP]
Async high level api
URL: https://github.com/apache/samza/pull/905#discussion_r262755910
##########
File path:
samza-core/src/main/java/org/apache/samza/task/StreamOperatorTask.java
##########
@@ -90,34 +94,56 @@ public final void init(Context context) throws Exception {
* @param ime incoming message envelope to process
* @param collector the collector to send messages with
* @param coordinator the coordinator to request commits or shutdown
+ * @param callback the task callback handle
*/
@Override
- public final void process(IncomingMessageEnvelope ime, MessageCollector
collector, TaskCoordinator coordinator) {
+ public final void processAsync(IncomingMessageEnvelope ime, MessageCollector
collector, TaskCoordinator coordinator,
+ TaskCallback callback) {
SystemStream systemStream =
ime.getSystemStreamPartition().getSystemStream();
InputOperatorImpl inputOpImpl =
operatorImplGraph.getInputOperator(systemStream);
if (inputOpImpl != null) {
- switch (MessageType.of(ime.getMessage())) {
+ CompletionStage<Void> processFuture;
+ MessageType messageType = MessageType.of(ime.getMessage());
+ switch (messageType) {
case USER_MESSAGE:
- inputOpImpl.onMessage(ime, collector, coordinator);
+ processFuture = inputOpImpl.onAsyncMessage(ime, collector,
coordinator);
Review comment:
s/onAsyncMessage/onMessageAsync
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
