Sanil15 edited a comment on issue #920: SAMZA-2106: Samza app and job config 
refactor
URL: https://github.com/apache/samza/pull/920#issuecomment-469444362
 
 
   @xinyuiscool not all the code that uses JOB.NAME, reads it of 
JobConfig#getName method and the same applies to JOB.ID
   
   With this approach, we can easily log warnings and convey users to move to 
app.id and app.name. Also, I like the idea that you told, everything until 
JobRunner should use app.name/app.id and once the job gets submitted to Yarn, 
then job uses job.id. With this design, it is easier to make that happen in 
future when we get rid of job.id/job.name from user-defined configs and do 
multi-staging

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to