prateekm commented on a change in pull request #942: Bugfix: Recent CSM
refactor was causing some metrics to not be emitted. Fixed <task>-restore-time
metric.
URL: https://github.com/apache/samza/pull/942#discussion_r263865477
##########
File path:
samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala
##########
@@ -879,9 +880,13 @@ class SamzaContainer(
}
def startMetrics {
- info("Registering task instances with metrics.")
-
- taskInstances.values.foreach(_.registerMetrics)
+ info("Registering taskInstanceMetrics.")
+ reporters.values.foreach(reporter => {
+ taskInstanceMetrics.values.foreach(taskMetrics => {
+ reporter.register(taskMetrics.source, taskMetrics.registry)
+ }
+ )
Review comment:
Nitpick: Move to previous line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
