mynameborat commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r262816170
########## File path: samza-core/src/main/java/org/apache/samza/coordinator/CoordinationUtils.java ########## @@ -28,6 +28,9 @@ * - LeaderElection * - Latch * - LockWithState (does not lock if state is set) + * - ReadWriteLock (lock to acquire read or write access) + * - DataAccess (to read or write data) + * - setCoordinationSessionListener to listen to coordination utils session state changes */ @InterfaceStability.Evolving public interface CoordinationUtils { Review comment: Can we add java documentation to the new APIs and provide contracts and framework's expectations from the implementers? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services