prateekm commented on a change in pull request #942: Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed <task>-restore-time metric. URL: https://github.com/apache/samza/pull/942#discussion_r263505840
########## File path: samza-core/src/main/scala/org/apache/samza/system/SystemConsumersMetrics.scala ########## @@ -19,12 +19,10 @@ package org.apache.samza.system -import org.apache.samza.metrics.MetricsRegistry -import org.apache.samza.metrics.MetricsRegistryMap -import org.apache.samza.metrics.Counter -import org.apache.samza.metrics.MetricsHelper +import org.apache.samza.metrics._ Review comment: Minor: Prefer explicit imports. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
