Thanks everybody for feedback!
Nice to see a lot of people participated in the discussion this week.
Based on the and some people being against having merge requests as
part of the recommended workflow, and some also objected having Salsa
CI as part of the team workflow, I decided to split that n
Hi,
Thanks everyone for the feedback, I have updated
https://salsa.debian.org/go-team/go-team.pages.debian.net/-/merge_requests/7
Direct link to artifact:
https://otto.pages.debian.net/-/go-team.pages.debian.net/-/jobs/6923949/artifacts/build/workflow-changes.html
On Tue, 14 Jan 2025 at 12:45, Ni
Thanks Nilesh and Simon for the feedback here, and thanks Maytham and
Taavi for posting feedback on the MR!
> About the "Give and get reviews" in your MR: to clarify, that is, in no way,
> mandatory right?
> I guess that from work "should" instead of "must".
The MR text says: "Reviews are recomm
Hi!
In line with what I have already been doing, I now published a draft
for workflow changes at
https://salsa.debian.org/go-team/go-team.pages.debian.net/-/merge_requests/7
Direct link to latest build artifact for convenience:
https://otto.pages.debian.net/-/go-team.pages.debian.net/-/jobs/69171
> I support enabling Salsa CI pipelines for all Go projects.
>
> I gave a GitLab merge request "thumbs up" now, but I feel that such
> indication is more about reviewing the actual code (which I'm not
> qualified to do) than to actually give you a +1 on the overall purpose.
Thanks! We are a team a
to paint the full picture of all my proposals combined
help to optimize the Go packaging workflow.
On Thu, 2 Jan 2025 at 00:27, Otto Kekäläinen wrote:
>
> Hi all!
>
> Next step in this list would be number 5.
>
> Changing defaults for new packages and a script to bulk upd
> But there are packages (e.g.,
> cosign) that ultimately Build-Depends on both, so both has to be
> installed at the same time.
Ah, in that case it makes sense to have both in the same package as
the workaround.
Hi,
The go-tuf version string 2.0.2+0.7.0-1 seems cryptic. How is the
package lifecycle planned to go if it actually contains the same
package twice?
Would it not be much simpler to just have two source packages in
Debian, just like all other packages that have multiple versions?
Hi all!
I found out about Gophian[1, 2] yesterday and I had no clue it
existed. It seems new, from summer 2025. I wonder how many people are
using it? What do you think about it?
I noticed Nicolas is working on
https://github.com/Debian/dh-make-golang/pull/240 which seems to have
been one of the
Hi!
> > > I think it would be a good idea to use the script at [1] to update all
> > > the Go team repos, after it's updated to account for the
> > > "%{project_path}" variable, as well as replacing
> > > "github.com/xanzy/go-gitlab" with its new import path.
> > >
> > > It also needs to be update
Hi,
> Does this mean that maintaining upstream Git history will be standard in
> the Go team?
Yes, it means that you can git blame on upstream code (outside of
debian/) and see what was introduced when, and you can run gbp switch
--force and git cherry-pick -x to backport fixes
from newer upstre
Hi!
> I'm in full support of these changes, thank you for working on this.
Thanks!
> I think it would be a good idea to use the script at [1] to update all
> the Go team repos, after it's updated to account for the
> "%{project_path}" variable, as well as replacing
> "github.com/xanzy/go-gitlab"
On Sat, 4 Jan 2025 at 22:19, Otto Kekäläinen wrote:
>
> Hi,
>
> Personally I use Files-Excluded in the d/copyright file and import
> with gbp import-orig which handles everything automatically correctly
> assuming the d/gbp.conf is configured correctly and has the
> upstream-
Hi,
Personally I use Files-Excluded in the d/copyright file and import
with gbp import-orig which handles everything automatically correctly
assuming the d/gbp.conf is configured correctly and has the
upstream-vcs-tag format so gbp can do the git merge. See the gbp.conf
template I suggest all pack
Hi Loren!
..
> > https://salsa.debian.org/go-team/packages/gh/-/merge_requests/3
> >
> > I manually started the Salsa CI job after filing the MR, but I see that
> > is it stuck waiting for a Runner in the provision stage due to no
> > available runners. Otto, is this because this is being run outs
Hi all!
Next step in this list would be number 5.
Changing defaults for new packages and a script to bulk update all
existing repositories posted at
https://salsa.debian.org/go-team/infra/pkg-go-tools/-/merge_requests/4
Feedback welcome!
On Thu, 5 Dec 2024 at 21:58, Otto Kekäläinen wrote
> OK, I've created a second merge request with a fix for another CVE. I've
> left it as a draft as I haven't had a chance to do manual testing of the
> feature yet.
Thanks! I already did first pass of review on
https://salsa.debian.org/go-team/packages/gh/-/merge_requests/2
Posting link here so ot
Hi Loren!
> We can hold off on the Bookworm update for a little bit if that would
> help. As this is my first attempt at getting a package into
> stable-updates, I am learning a bit myself. Another developer pointed me
> at the appropriate part of the developer reference for this so I realize
> th
Hi,
> > If there is a true emergency then sure, go ahead an upload a package
> > without coordination. But this wasn't so urgent, Santiago could have
> > easily waited one or two days instead of the 2h he did now. Just
> > waiting a bit longer isn't that much extra work, it is just a matter
> > of
> >> You bypassed now both code reviews and uploaded despite failing CI.
>
> As far as I know, there's no hard-bound team policy to upload only when
> the pipeline passes.
No, there isn't a policy, but the pipeline here isn't the main point
here. Do you notice the culture aspect of hero behavior v
Hi all,
There are currently 91 open merge requests in the Go team:
https://salsa.debian.org/groups/go-team/-/merge_requests
Some of them might be stalled for various reasons, but I there are
many that are genuinely pending review/feedback. If you have some
spare time, please go and check out a co
Hi Loren!
> As this package doesn't really follow the dh-make-golang workflow, I did
> not have as much documentation to go with (no pun intended). Does
> uploading a package to mentors help here or is just making a fork on
> Salsa the best way to go here? Is there a BKM I should be following
> he
The CVE is two months old, it alone isn't a reason to rush an upload within
hours specifically today.
I am just trying to highlight here that while it is good that we have
heroes who do a bunch of solo work for Debian, doing things a bit slower
and inclusively will help build teams and grow colla
Hi Santiago!
I see you now tagged debian/2.46.0-2 and likely uploaded it.
Why were you in such a hurry? Why couldn't you let the Go team take care of
this?
You bypassed now both code reviews and uploaded despite failing CI.
I am glad you put work into this but it would have been more collaborat
Hi!
On Wed, 18 Sept 2024 at 11:48, Louis-Philippe Véronneau
wrote:
>
> On 2024-09-15 11:45, Otto Kekäläinen wrote:
> > Hi!
> >
> >>> I was reviewing a new Debian package at
> >>> https://salsa.debian.org/lintian/lintian-ssg/-/merge_requests/2 where
&
Hi all,
> 4. Start running Salsa CI on Go team packages manually
>
> The current Go team CI run is incomprehensible to me. It does at least
> *not* test the most important thing a CI in Debian should do, which is
> to tell if a package builds in Debian or not. This can be fixed right
> away by mak
Hi!
> I'm trying to package the soci-snapshotter for nerdctl. This package
> requires and embeds a patched copy of zlib, and I've added a lintian
> override for this reason:
> https://salsa.debian.org/go-team/packages/golang-github-awslabs-soci-snapshotter/-/blob/a7bf099/debian/soci-snapshotter.li
Hi!
Can somebody press the "Approve" button at
https://salsa.debian.org/go-team/infra/pkg-go-tools/-/merge_requests/2
so I feel confident merging it?
The current Salsa CI pipeline in go-team does not test if the Go
package can build so having basic Salsa CI capability seems like an
obvious thing
Hi,
> The extra permissions the owners have is related to some security
> things and role management and the likes iirc. I believe the
> documentation[0] has the full info.
>
> --
> Best,
> Ananthu
>
> [0] - https://docs.gitlab.com/ee/user/permissions.html
>
> On 17 December 2024 7:35:33 am UTC, S
you
could add me as the 97th DD with owner permissions in the group.
On Tue, 3 Dec 2024 at 22:42, Otto Kekäläinen wrote:
>
> Hi Aloïs and Anthony!
>
> I know the packages are team maintained, but just to be sure I wanted
> to check if you are OK if I update the mentioned packages
Hi,
> > https://github.com/Debian/dh-make-golang/blob/d70d43c2c98bd8419d41c7dc741ece4bff437ff1/make.go#L575
> >
> > We maintain a list of well-known hosts. If you want to change the
> > value for this host, please submit PR against this list.
> > dh-make-golang also says that:
>
> I just looked at
Hi,
I wanted to bump up this once more, and remind that each suggestion has a
corresponding MR/PR which you can "thumbs up" in Salsa/GitHub as a token of
approval.
..or thumbs down to show that oppose it so I know not to merge it in
coming month.
On Thu., Dec. 5, 2024, 21:58 Otto
Hi Ahmad!
I use personally nfty and I am happy to provide reviews to MRs on Salsa for
the various subtasks you are working on here.
Simon already replied on your questions. Additionally I suggest you ask
upstream what they recommend as the best was to build ntfy without Stripe.
That way you can m
Hi!
On Sat, 7 Dec 2024 at 05:45, Nilesh Patra wrote:
> On 07/12/24 5:37 pm, Simon Josefsson wrote:
> > I think we exagerate the salsa CI load concerns. My perception is that
> > while the Go package system is substantial, the churn is actually fairly
> > low and building Go packages is much faste
Hi Simon and others,
Can somebody grant me admin permissions to the equivalent
go-team/packages repos so I can modernize them and have Salsa CI
properly enabled?
> https://salsa.debian.org/go-team/packages/golang-github-charmbracelet-glamour
> https://salsa.debian.org/go-team/packages/golang-gith
Hi,
I am about to upload these packages to Debian unstable:
https://salsa.debian.org/otto/golang-github-charmbracelet-glamour
https://salsa.debian.org/otto/golang-github-muesli-gitcha
https://salsa.debian.org/otto/golang-github-caarlos0-env
They have already been discussed on this list, they are
Hi!
> > 1. Switch to most recent and final DEP14 names 'debian/latest' and
> > 'upstream/latest': https://github.com/Debian/dh-make-golang/pull/225
> >
> > Go team already follows DEP14 since 2019, but the standard evolved, so
> > Go team should update accordingly. We can start doing this in new
>
Hi all Go team members,
I am proposing we update the Go team workflow for 2025 on a few points:
1. Switch to most recent and final DEP14 names 'debian/latest' and
'upstream/latest': https://github.com/Debian/dh-make-golang/pull/225
Go team already follows DEP14 since 2019, but the standard evolv
Thanks Simon for working on this!
Can you point to a man page or blog post or README to help people like
me learn what this is and how it is designed to be used?
Hi Aloïs and Anthony!
I know the packages are team maintained, but just to be sure I wanted
to check if you are OK if I update the mentioned packages to latest
version, ask for review on this list and then upload to unstable? I
already did test imports and reverse dep builds in my fork so I know
i
Hi,
I am about to upload these packages to NEW:
https://salsa.debian.org/go-team/packages/golang-github-muesli-mango-pflag
https://salsa.debian.org/go-team/packages/golang-github-muesli-mango-cobra
https://salsa.debian.org/go-team/packages/glow
They have already been discussed on this list, they
Hi!
Thanks for the tips! I think I prefer the dak method, as it does not
require me to update/fetch package lists locally, and it has sensible
output that confirms if I used the correct package name.
± ssh mirror.ftp-master.debian.org "dak rm -Rn -b golang-github-muesli-gitcha"
Nothing to do.
±
Hi!
I am planning to upload new versions of some Go libraries, and before
doing it I wanted to test that the reverse dependencies don't break.
However, for these two I can't find any:
# apt-cache rdepends golang-github-caarlos0-env
E: No packages found
# apt-cache rdepends golang-github-caarlos0-
Thanks Nicolas for pointing out off-thread that dh_golang already had these:
DH_GOLANG_EXCLUDES
DH_GOLANG_EXCLUDES_ALL
https://manpages.debian.org/unstable/dh-golang/Debian::Debhelper::Buildsystem::golang.3pm.en.html#DH_GOLANG_EXCLUDES
I switched to using these in all the packages and it works w
> > I wonder if Go in Debian has something like ${misc:Go-Depends} similar
> > how C programs will automatically populate the correct run-time
> > libraries based on what was used during the build into the
> > ${shlibs:Depends} variable.
>
> I don't think there's something like this for Go debhelpe
Hi Nicolas!
> > That in turn leads down another rabbit hole, as
> > updating these libraries need to be tested for compatibility with
> > existing packages, and a quick rdepends test build on e.g.
> > https://salsa.debian.org/otto/golang-github-charmbracelet-glamour/-/pipelines/770887
> > shows th
Hi!
I filed the estimate bug at https://github.com/Debian/dh-make-golang/issues/231
This command I had not tried before turned out very useful:
# dh-make-golang check-depends
NEW dependency github.com/charmbracelet/lipgloss
(golang-github-charmbracelet-lipgloss-dev)
NEW dependency github.com/cha
Hi!
While working on Go packages recently, I noticed many of them have the
subdirectories
examples/
testdata/
The stuff in examples/ is shipped in many Debian packages currently in
the binary deb files. In one case the examples/ even lead to a
/usr/bin/example being generated and it would have go
Hi!
> Yes. See go.mod for required versions.
> https://salsa.debian.org/go-team/packages/glow/-/blob/debian/latest/go.mod?ref_type=heads#L10
It is a bit too much to manually go through each one. Also, that is
not needed most of the time, as running dh-make-golang itsel already
does a pretty decen
Thanks Nicolas and weepingclown for the pointer, indeed I overlooked
that "v11" string. I am working on importing latest 11.2.2 at
https://salsa.debian.org/otto/golang-github-caarlos0-env/-/commits/debian/latest
and will test building with it. I have both locally and in CI
https://salsa.debian.org/
Hi,
In https://salsa.debian.org/go-team/packages/glow/-/jobs/6665802 the
build of Glow fails to load github.com/caarlos0/env/v11. Can anybody
help me understand why?
The dependency exists in Debian
(https://packages.debian.org/sid/golang-github-caarlos0-env-dev) and
is properly as build-depends.
Hi,
If anyone has spare time to review, I'd like to get feedback about
https://salsa.debian.org/go-team/packages/golang-github-muesli-mango-cobra/-/commits/debian/latest
It is very similar to the golang-github-muesli-mango-pflag I shared on
this list a couple of days ago.
Note that in this Go te
Hi!
Did you notice Debian build is failing in CI?
https://salsa.debian.org/jas/gitsign/-/jobs/6661378
> Another solution could be a debian/not-installed file, if you prefer to
> not override dh_auto_install like the above.
That file is actually only to allowlist files that are built, but not
included in the package. Normally in modern Debhelper builds the
packages fail on file mismatches if there
> > If any of you have have spare time, I'd appreciate a review of
> > https://salsa.debian.org/go-team/packages/golang-github-muesli-mango-pflag
> > before I upload.
>
> Looks good to me.
>
> Instead of the patch I would have added in debian/rules:
>
> override_dh_auto_install:
> dh_auto_i
Hi!
It works, thanks!
If any of you have have spare time, I'd appreciate a review of
https://salsa.debian.org/go-team/packages/golang-github-muesli-mango-pflag
before I upload.
Commits:
https://salsa.debian.org/go-team/packages/golang-github-muesli-mango-pflag/-/commits/debian/latest
CI:
https
Hi!
Can somebody with team-level permissions grant me project-level admin
access to the projects:
https://salsa.debian.org/go-team/packages/glow
https://salsa.debian.org/go-team/packages/golang-github-muesli-mango-cobra
https://salsa.debian.org/go-team/packages/golang-github-muesli-mango-pflag
i
Hi all!
Thanks for multiple replies on the topic after a couple weeks of
silence. I am already in progress doing the things suggested here, and
now with the additional feedback I think I can finalize everything
today in https://salsa.debian.org/go-team/infra/pkg-go-tools/-/merge_requests/2
and sta
-client/-/pipelines/751593
...
> > On Tue, 17 Sept 2024 at 01:16, Otto Kekäläinen wrote:
> > >
> > > Hi!
> > >
> > > I noticed the Go team has docs for having your own Salsa CI runner:
> > > https://go-team.pages.debian.net/ci.html
> > >
>
Hi,
Thanks Reinhard for approving the MR below!
I do not have Merge permissions, so I haven't been able to merge it myself.
On Sun, 27 Oct 2024 at 13:58, Otto Kekäläinen wrote:
>
> Hi!
>
> Go team feedback about Salsa CI docs in particular about runners is
> still welcome a
:
https://salsa.debian.org/go-team/infra/pkg-go-tools/-/merge_requests/1
On Tue, 17 Sept 2024 at 01:16, Otto Kekäläinen wrote:
>
> Hi!
>
> I noticed the Go team has docs for having your own Salsa CI runner:
> https://go-team.pages.debian.net/ci.html
>
> There are also Ansible sc
Hi!
On Thu, 10 Oct 2024 at 04:40, Otto Kekäläinen wrote:
>
> Hi!
>
> There are two new Go packages pending review at
>
> https://mentors.debian.net/package/prometheus-phpfpm-exporter/
> (https://salsa.debian.org/go-team/packages/prometheus-phpfpm-exporter/)
>
> https:/
Hi!
There are two new Go packages pending review at
https://mentors.debian.net/package/prometheus-phpfpm-exporter/
(https://salsa.debian.org/go-team/packages/prometheus-phpfpm-exporter/)
https://mentors.debian.net/package/golang-github-tomasen-fcgi-client/
(https://salsa.debian.org/go-team/packa
Hi!
I noticed the Go team has docs for having your own Salsa CI runner:
https://go-team.pages.debian.net/ci.html
There are also Ansible scripts to deploy it at
https://salsa.debian.org/go-team/infra/provisioning/-/tree/master/ci-runner,
though the runner configuration is not fully identical to th
Hi!
> > I was reviewing a new Debian package at
> > https://salsa.debian.org/lintian/lintian-ssg/-/merge_requests/2 where
> > Lintian nags about `statically-linked-binary`.
>
> Please help moving this MP[1] so lintian stops nagging
> `statically-linked-binary` for your package.
>
> [1] https://sal
Hi!
I was reviewing a new Debian package at
https://salsa.debian.org/lintian/lintian-ssg/-/merge_requests/2 where
Lintian nags about `statically-linked-binary`.
I have been reading
https://manpages.debian.org/unstable/dh-golang/dh_golang.1p.en.html
about `Static-Built-Using: ${misc:Static-Built-U
66 matches
Mail list logo
