Hi!
> > > I think it would be a good idea to use the script at [1] to update all
> > > the Go team repos, after it's updated to account for the
> > > "%{project_path}" variable, as well as replacing
> > > "github.com/xanzy/go-gitlab" with its new import path.
> > >
> > > It also needs to be updated in dh-make-golang[2] and gophian[3], with
> > > the "%{project_path}" variable again accounted for.
> >
> > I don't quite follow, what does "%{project_path}" have to do with line:
> > > const gitlabciymlTmpl = `# auto-generated, DO NOT MODIFY.
>
> It's not only that line, it's the whole template string hardcoded within
> these programs. Your updates to pkg-go-tools added comments to the
> bottom of the template that reference this variable:
>
> # If Salsa CI is not running at
> # https://salsa.debian.org/%{project_path}/-/pipelines, ensure that
> # https://salsa.debian.org/%{project_path}/-/settings/ci_cd has in field
> "CI/CD
> # configuration file" the same filename as this file.
> #
> # If Salsa CI is running, but first job is stuck because the project doesn't
> # have any runners online assigned to it, ensure that
> # https://salsa.debian.org/%{project_path}/-/settings/ci_cd has under
> "Runners"
> # the setting for "Enable instance runners for this project" enabled.
>
> Unless we want it to remain like that the next time someone uses
> dh-make-golang or gophian, these tools will need to replace
> %{project_path} with the actual repo path so the generated file is
> %correct.
Oh now I got it. Those variables are intended to stay as variables.
They are just placeholders and it is up to the human reading the
comment to figure out that they need to parse it and not copy-paste
the url verbatim. I have no intent to automate them.
In https://salsa.debian.org/salsa-ci-team/pipeline/-/merge_requests/563
I am planning to have "upstream" Salsa CI have a template like:
# This is a template from
#
https://salsa.debian.org/salsa-ci-team/pipeline/-/raw/master/recipes/salsa-ci.yml
#
# If this pipeline is not running at after committing and pushing this file,
# ensure that https://salsa.debian.org/%{project_path}/-/settings/ci_cd has in
# field "CI/CD configuration file" filename "debian/salsa-ci.yml".
#
# Feel free disable and enable tests to find a good balance between extensive
# coverage and having a consistently green pipeline where failures are rare
# enough that they are always investigated and addressed. For documeenation
# please read https://salsa.debian.org/salsa-ci-team/pipeline
---
include:
- https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/recipes/debian.yml
> > If you have a clear vision what to change, please file Merge Request
> > and assign me as reviewer, and I will dive into it and try to help you
> > finalize it.
>
> I've submitted a PR against dh-make-golang at [1] and have already
> updated gophian at [2].
Nice! Added my approval in [1]
